Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(858)

Unified Diff: runtime/vm/object.h

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object.h
diff --git a/runtime/vm/object.h b/runtime/vm/object.h
index fbd0ec72f1d95b116dcdddf5ca001682c3446607..143cf9e409ac4647df55b2b7b58f3ad3ea61cb2e 100644
--- a/runtime/vm/object.h
+++ b/runtime/vm/object.h
@@ -25,7 +25,6 @@
#include "vm/tags.h"
#include "vm/thread.h"
#include "vm/token_position.h"
-#include "vm/verified_memory.h"
namespace dart {
@@ -655,7 +654,6 @@ class Object {
ASSERT(Contains(reinterpret_cast<uword>(to)));
if (raw()->IsNewObject()) {
memmove(const_cast<RawObject**>(to), from, count * kWordSize);
- VerifiedMemory::Accept(reinterpret_cast<uword>(to), count * kWordSize);
} else {
for (intptr_t i = 0; i < count; ++i) {
StorePointer(&to[i], from[i]);
@@ -7440,7 +7438,7 @@ class GrowableObjectArray : public Instance {
ASSERT(index < Length());
// TODO(iposva): Add storing NoSafepointScope.
- DataStorePointer(ObjectAddr(index), value.raw());
+ data()->StorePointer(ObjectAddr(index), value.raw());
}
void Add(const Object& value, Heap::Space space = Heap::kNew) const;
@@ -7510,9 +7508,6 @@ class GrowableObjectArray : public Instance {
ASSERT((index >= 0) && (index < Length()));
return &(DataArray()->data()[index]);
}
- void DataStorePointer(RawObject** addr, RawObject* value) const {
- data()->StorePointer(addr, value);
- }
static const int kDefaultInitialCapacity = 4;
« no previous file with comments | « runtime/vm/jit_optimizer.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698