Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Unified Diff: runtime/vm/assembler_ia32.h

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/assembler_ia32.h
diff --git a/runtime/vm/assembler_ia32.h b/runtime/vm/assembler_ia32.h
index 5753792de0e94d3f727dc6bfd67c7e56a4c68699..77f77a66b2bfba1c83e28b4827006d6cc0a227dc 100644
--- a/runtime/vm/assembler_ia32.h
+++ b/runtime/vm/assembler_ia32.h
@@ -636,12 +636,10 @@ class Assembler : public ValueObject {
return 0xCCCCCCCC;
}
- // Note: verified_mem mode forces far jumps.
void j(Condition condition, Label* label, bool near = kFarJump);
void j(Condition condition, const ExternalLabel* label);
void jmp(Register reg);
- // Note: verified_mem mode forces far jumps.
void jmp(Label* label, bool near = kFarJump);
void jmp(const ExternalLabel* label);
@@ -677,14 +675,6 @@ class Assembler : public ValueObject {
void CompareObject(Register reg, const Object& object);
void LoadDoubleConstant(XmmRegister dst, double value);
- // When storing into a heap object field, knowledge of the previous content
- // is expressed through these constants.
- enum FieldContent {
- kEmptyOrSmiOrNull, // Empty = garbage/zapped in release/debug mode.
- kHeapObjectOrSmi,
- kOnlySmi,
- };
-
void StoreIntoObject(Register object, // Object we are storing into.
const Address& dest, // Where we are storing into.
Register value, // Value we are storing.
@@ -692,22 +682,10 @@ class Assembler : public ValueObject {
void StoreIntoObjectNoBarrier(Register object,
const Address& dest,
- Register value,
- FieldContent old_content = kHeapObjectOrSmi);
- void InitializeFieldNoBarrier(Register object,
- const Address& dest,
- Register value) {
- return StoreIntoObjectNoBarrier(object, dest, value, kEmptyOrSmiOrNull);
- }
+ Register value);
void StoreIntoObjectNoBarrier(Register object,
const Address& dest,
- const Object& value,
- FieldContent old_content = kHeapObjectOrSmi);
- void InitializeFieldNoBarrier(Register object,
- const Address& dest,
- const Object& value) {
- return StoreIntoObjectNoBarrier(object, dest, value, kEmptyOrSmiOrNull);
- }
+ const Object& value);
// Stores a Smi value into a heap object field that always contains a Smi.
void StoreIntoSmiField(const Address& dest, Register value);
@@ -1009,17 +987,6 @@ class Assembler : public ValueObject {
void StoreIntoObjectFilterNoSmi(Register object,
Register value,
Label* no_update);
-#if defined(DEBUG)
- void VerifyUninitialized(const Address& address);
- void VerifyObjectOrSmi(const Address& address);
- void VerifySmi(const Address& address, const char* stop_msg = "Expected Smi");
-#endif // DEBUG
- // Like VerifiedMemory::Verify(address, kWordSize) and ::Write, but also,
- // in DEBUG mode, verifies that 'address' has content of type 'old_content'.
- void VerifyHeapWord(const Address& address, FieldContent old_content);
- void VerifiedWrite(const Address& dest,
- Register value,
- FieldContent old_content);
void UnverifiedStoreOldObject(const Address& dest, const Object& value);
int32_t jit_cookie();
« no previous file with comments | « runtime/vm/assembler_arm.cc ('k') | runtime/vm/assembler_ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698