Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Side by Side Diff: runtime/vm/intermediate_language_mips.cc

Issue 2112043002: Land Ivan's change of 'Remove support for verified memory handling' (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Address code review comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS. 5 #include "vm/globals.h" // Needed here to get TARGET_ARCH_MIPS.
6 #if defined(TARGET_ARCH_MIPS) 6 #if defined(TARGET_ARCH_MIPS)
7 7
8 #include "vm/intermediate_language.h" 8 #include "vm/intermediate_language.h"
9 9
10 #include "vm/compiler.h" 10 #include "vm/compiler.h"
(...skipping 1904 matching lines...) Expand 10 before | Expand all | Expand 10 after
1915 1915
1916 1916
1917 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Zone* zone, 1917 LocationSummary* StoreInstanceFieldInstr::MakeLocationSummary(Zone* zone,
1918 bool opt) const { 1918 bool opt) const {
1919 const intptr_t kNumInputs = 2; 1919 const intptr_t kNumInputs = 2;
1920 const intptr_t kNumTemps = 1920 const intptr_t kNumTemps =
1921 (IsUnboxedStore() && opt) ? 2 : 1921 (IsUnboxedStore() && opt) ? 2 :
1922 ((IsPotentialUnboxedStore()) ? 3 : 0); 1922 ((IsPotentialUnboxedStore()) ? 3 : 0);
1923 LocationSummary* summary = new(zone) LocationSummary( 1923 LocationSummary* summary = new(zone) LocationSummary(
1924 zone, kNumInputs, kNumTemps, 1924 zone, kNumInputs, kNumTemps,
1925 ((IsUnboxedStore() && opt && is_potential_unboxed_initialization_) || 1925 ((IsUnboxedStore() && opt && is_initialization()) ||
1926 IsPotentialUnboxedStore()) 1926 IsPotentialUnboxedStore())
1927 ? LocationSummary::kCallOnSlowPath 1927 ? LocationSummary::kCallOnSlowPath
1928 : LocationSummary::kNoCall); 1928 : LocationSummary::kNoCall);
1929 1929
1930 summary->set_in(0, Location::RequiresRegister()); 1930 summary->set_in(0, Location::RequiresRegister());
1931 if (IsUnboxedStore() && opt) { 1931 if (IsUnboxedStore() && opt) {
1932 summary->set_in(1, Location::RequiresFpuRegister()); 1932 summary->set_in(1, Location::RequiresFpuRegister());
1933 summary->set_temp(0, Location::RequiresRegister()); 1933 summary->set_temp(0, Location::RequiresRegister());
1934 summary->set_temp(1, Location::RequiresRegister()); 1934 summary->set_temp(1, Location::RequiresRegister());
1935 } else if (IsPotentialUnboxedStore()) { 1935 } else if (IsPotentialUnboxedStore()) {
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
1971 Label skip_store; 1971 Label skip_store;
1972 1972
1973 Register instance_reg = locs()->in(0).reg(); 1973 Register instance_reg = locs()->in(0).reg();
1974 1974
1975 if (IsUnboxedStore() && compiler->is_optimizing()) { 1975 if (IsUnboxedStore() && compiler->is_optimizing()) {
1976 DRegister value = locs()->in(1).fpu_reg(); 1976 DRegister value = locs()->in(1).fpu_reg();
1977 Register temp = locs()->temp(0).reg(); 1977 Register temp = locs()->temp(0).reg();
1978 Register temp2 = locs()->temp(1).reg(); 1978 Register temp2 = locs()->temp(1).reg();
1979 const intptr_t cid = field().UnboxedFieldCid(); 1979 const intptr_t cid = field().UnboxedFieldCid();
1980 1980
1981 if (is_potential_unboxed_initialization_) { 1981 if (is_initialization()) {
1982 const Class* cls = NULL; 1982 const Class* cls = NULL;
1983 switch (cid) { 1983 switch (cid) {
1984 case kDoubleCid: 1984 case kDoubleCid:
1985 cls = &compiler->double_class(); 1985 cls = &compiler->double_class();
1986 break; 1986 break;
1987 default: 1987 default:
1988 UNREACHABLE(); 1988 UNREACHABLE();
1989 } 1989 }
1990 1990
1991 BoxAllocationSlowPath::Allocate(compiler, this, *cls, temp, temp2); 1991 BoxAllocationSlowPath::Allocate(compiler, this, *cls, temp, temp2);
(...skipping 3735 matching lines...) Expand 10 before | Expand all | Expand 10 after
5727 1, 5727 1,
5728 locs()); 5728 locs());
5729 __ lw(result, Address(SP, 1 * kWordSize)); 5729 __ lw(result, Address(SP, 1 * kWordSize));
5730 __ addiu(SP, SP, Immediate(2 * kWordSize)); 5730 __ addiu(SP, SP, Immediate(2 * kWordSize));
5731 } 5731 }
5732 5732
5733 5733
5734 } // namespace dart 5734 } // namespace dart
5735 5735
5736 #endif // defined TARGET_ARCH_MIPS 5736 #endif // defined TARGET_ARCH_MIPS
OLDNEW
« no previous file with comments | « runtime/vm/intermediate_language_ia32.cc ('k') | runtime/vm/intermediate_language_x64.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698