chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js - Issue 2112033002: [MD settings] closure compilation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

Issue 2112033002: [MD settings] closure compilation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js ('K') | « chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_browser_proxy.js ('k') | chrome/browser/resources/settings/clear_browsing_data_dialog/compiled_resources2.gyp » ('j') | chrome/browser/resources/settings/default_browser_page/default_browser_page.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

diff --git a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

index b094d5983c685e4c116ee19ba15728a88f21cd38..a374304bbeccff3459dc4982ebd92d0a460b319e 100644

--- a/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

+++ b/chrome/browser/resources/settings/clear_browsing_data_dialog/clear_browsing_data_dialog.js

@@ -35,7 +35,7 @@ Polymer({

/**

* List of options for the dropdown menu.

- * @private {!DropdownMenuOptionList>}

+ * @private {!DropdownMenuOptionList}

clearFromOptions_: {

readOnly: true,

@@ -59,7 +59,7 @@ Polymer({

- /** @private {!settings.ClearBrowsingDataBrowserProxy} */

+ /** @private {settings.ClearBrowsingDataBrowserProxy} */

tommycli 2016/06/30 21:29:42 If this type is changed to ClearBrowsingDataBrowse

Dan Beam 2016/06/30 22:35:33 that's true, but kind of defeats the purpose of an

browserProxy_: null,

/** @override */

@@ -112,7 +112,7 @@ Polymer({

* Updates the text of a browsing data counter corresponding to the given

* preference.

* @param {string} prefName Browsing data type deletion preference.

- * @param {text} text The text with which to update the counter

+ * @param {string} text The text with which to update the counter

* @private

updateCounterText_: function(prefName, text) {