Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h

Issue 2112013002: Allow arc app to lock screen orientation in TouchView/Tablet mode (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: unit test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
diff --git a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
index c4f9f2fb95ce72f415003b323b02b391fb8b4f80..2ae65d58334cccc51d5e8507ce4abc8d368c8306 100644
--- a/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
+++ b/chrome/browser/ui/app_list/arc/arc_app_list_prefs.h
@@ -60,7 +60,8 @@ class ArcAppListPrefs : public KeyedService,
bool notifications_enabled,
bool ready,
bool showInLauncher,
- bool shortcut);
+ bool shortcut,
+ arc::mojom::OrientationLock orientation_lock);
~AppInfo();
std::string name;
@@ -74,6 +75,7 @@ class ArcAppListPrefs : public KeyedService,
bool ready;
bool showInLauncher;
bool shortcut;
+ arc::mojom::OrientationLock orientation_lock;
};
struct PackageInfo {
@@ -118,6 +120,10 @@ class ArcAppListPrefs : public KeyedService,
virtual void OnNotificationsEnabledChanged(
const std::string& package_name, bool enabled) {}
+ virtual void OnTaskOrientationLockRequested(
+ int32_t task_id,
+ const arc::mojom::OrientationLock orientation_lock) {}
+
protected:
virtual ~Observer() {}
};
@@ -192,7 +198,9 @@ class ArcAppListPrefs : public KeyedService,
void RemoveApp(const std::string& app_id);
private:
- FRIEND_TEST_ALL_PREFIXES(ChromeLauncherControllerImplTest, ArcAppPinPolicy);
+ friend class ChromeLauncherControllerImplTest;
+ // FRIEND_TEST_ALL_PREFIXES(ChromeLauncherControllerImplTest,
+ // ArcAppPinPolicy);
// See the Create methods.
ArcAppListPrefs(const base::FilePath& base_path, PrefService* prefs);
@@ -225,6 +233,9 @@ class ArcAppListPrefs : public KeyedService,
void OnPackageModified(arc::mojom::ArcPackageInfoPtr package_info) override;
void OnPackageListRefreshed(
mojo::Array<arc::mojom::ArcPackageInfoPtr> packages) override;
+ void OnTaskOrientationLockRequested(
+ int32_t task_id,
+ const arc::mojom::OrientationLock orientation_lock) override;
void AddAppAndShortcut(const std::string& name,
const std::string& package_name,
@@ -233,7 +244,8 @@ class ArcAppListPrefs : public KeyedService,
const std::string& icon_resource_id,
const bool sticky,
const bool notifications_enabled,
- const bool shortcut);
+ const bool shortcut,
+ arc::mojom::OrientationLock orientation_lock);
void DisableAllApps();
void RemoveAllApps();
std::vector<std::string> GetAppIdsNoArcEnabledCheck() const;

Powered by Google App Engine
This is Rietveld 408576698