Convert video-canvas* and video-capture* tests to testharness.js

Convert video-canvas* and video-capture* tests to testharness.js

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
Committed: https://crrev.com/6ff44f5b8e053f33ba5dd730fac7ddfc0f5b566a
Cr-Commit-Position: refs/heads/master@{#403411}

[Srirama, 2016-06-30 17:48:06]

Description was changed from

==========
fix


fix

BUG=
==========

to

==========
Convert video-canvas* and video-capture* tests to testharness.js

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[Srirama, 2016-06-30 17:55:33]

Patchset #1 (id:1) has been deleted

[Srirama, 2016-06-30 17:58:40]

srirama.m@samsung.com changed reviewers:
+ foolip@chromium.org, fs@opera.com

[Srirama, 2016-06-30 17:58:41]

PTAL

[fs, 2016-06-30 18:43:42]

LGTM w/ a few nits and a question

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-capture-canvas.html (right):

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-canvas.html:13: function
gotStream(stream) {
Use an anonymous function?

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-canvas.html:18: function
getStreamFailed(error) {
Use t.unreached_func() instead of this?

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-capture-preview.html (right):

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:17: function
gotStream(stream) {
Could be anonymous or step_func?

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:20:
video.oncanplaythrough = t.step_func(function() {
Not quite sure above what the old strategy had going for it, but 2.5s timeout
are certainly something worth avoiding... Could you elaborate on why this is
just as good though?

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:30: function
getStreamFailed(error) {
Like in test above.

[Srirama, 2016-06-30 19:16:22]

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-capture-canvas.html (right):

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-canvas.html:13: function
gotStream(stream) {
On 2016/06/30 18:43:42, fs wrote:
> Use an anonymous function?

Done.

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-canvas.html:18: function
getStreamFailed(error) {
On 2016/06/30 18:43:42, fs wrote:
> Use t.unreached_func() instead of this?

Done.

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-capture-preview.html (right):

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:17: function
gotStream(stream) {
On 2016/06/30 18:43:42, fs wrote:
> Could be anonymous or step_func?

Done.

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:20:
video.oncanplaythrough = t.step_func(function() {
On 2016/06/30 18:43:42, fs wrote:
> Not quite sure above what the old strategy had going for it, but 2.5s timeout
> are certainly something worth avoiding... Could you elaborate on why this is
> just as good though?

It would have buffered most of the video by this time, though playing would have
not started. So i thought "oncanplaythrough" is a good event to bank on, to
avoid 2.5s timeout. Or should we wait for a timeupdate event instead of this, to
make sure video has played a bit?

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:30: function
getStreamFailed(error) {
On 2016/06/30 18:43:42, fs wrote:
> Like in test above.

Done.

[fs, 2016-06-30 19:21:12]

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/media/video-capture-preview.html (right):

https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/video-capture-preview.html:20:
video.oncanplaythrough = t.step_func(function() {
On 2016/06/30 at 19:16:22, Srirama wrote:
> On 2016/06/30 18:43:42, fs wrote:
> > Not quite sure above what the old strategy had going for it, but 2.5s
timeout
> > are certainly something worth avoiding... Could you elaborate on why this is
> > just as good though?
> 
> It would have buffered most of the video by this time, though playing would
have not started. So i thought "oncanplaythrough" is a good event to bank on, to
avoid 2.5s timeout. Or should we wait for a timeupdate event instead of this, to
make sure video has played a bit?

We should probably play it safe, so go with timeupdate. (Should mean a good
improvement from 2.5+2.5s still...)

[Srirama, 2016-07-01 03:45:29]

On 2016/06/30 19:21:12, fs wrote:
>
https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
> File third_party/WebKit/LayoutTests/media/video-capture-preview.html (right):
> 
>
https://codereview.chromium.org/2112003002/diff/20001/third_party/WebKit/Layo...
> third_party/WebKit/LayoutTests/media/video-capture-preview.html:20:
> video.oncanplaythrough = t.step_func(function() {
> On 2016/06/30 at 19:16:22, Srirama wrote:
> > On 2016/06/30 18:43:42, fs wrote:
> > > Not quite sure above what the old strategy had going for it, but 2.5s
> timeout
> > > are certainly something worth avoiding... Could you elaborate on why this
is
> > > just as good though?
> > 
> > It would have buffered most of the video by this time, though playing would
> have not started. So i thought "oncanplaythrough" is a good event to bank on,
to
> avoid 2.5s timeout. Or should we wait for a timeupdate event instead of this,
to
> make sure video has played a bit?
> 
> We should probably play it safe, so go with timeupdate. (Should mean a good
> improvement from 2.5+2.5s still...)

agreed and done.

[Srirama, 2016-07-01 03:48:57]

The CQ bit was checked by srirama.m@samsung.com

[Srirama, 2016-07-01 03:48:57]

The patchset sent to the CQ was uploaded after l-g-t-m from fs@opera.com
Link to the patchset: https://codereview.chromium.org/2112003002/#ps60001
(title: "use timeupdate event")

[commit-bot: I haz the power, 2016-07-01 03:49:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-01 05:14:41]

Description was changed from

==========
Convert video-canvas* and video-capture* tests to testharness.js

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-canvas* and video-capture* tests to testharness.js

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

[commit-bot: I haz the power, 2016-07-01 05:14:41]

Committed patchset #3 (id:60001)

[commit-bot: I haz the power, 2016-07-01 05:16:12]

Description was changed from

==========
Convert video-canvas* and video-capture* tests to testharness.js

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956
==========

to

==========
Convert video-canvas* and video-capture* tests to testharness.js

Cleaning up video-canvas* and video-capture* tests in
media/ to use testharness.js instead of video-test.js.
This will enable to upstream these tests to web-platform-tests.

BUG=588956

Committed: https://crrev.com/6ff44f5b8e053f33ba5dd730fac7ddfc0f5b566a
Cr-Commit-Position: refs/heads/master@{#403411}
==========

[commit-bot: I haz the power, 2016-07-01 05:16:13]

Patchset 3 (id:??) landed as
https://crrev.com/6ff44f5b8e053f33ba5dd730fac7ddfc0f5b566a
Cr-Commit-Position: refs/heads/master@{#403411}