ARM Skia NEON patches - 15 - Preparation work for Blitmask optims

src/opts/SkBlitRow_opts_arm.cpp

 /*
  * Copyright 2012 The Android Open Source Project
  *
  * Use of this source code is governed by a BSD-style license that can be
  * found in the LICENSE file.
  */
 
 #include "SkBlitRow_opts_arm.h"
 
 #include "SkBlitMask.h"
@@ skipping 353 matching lines @@
 SkBlitRow::Proc32 SkBlitRow::PlatformProcs32(unsigned flags) {
     return SK_ARM_NEON_WRAP(sk_blitrow_platform_32_procs_arm)[flags];
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 #define Color32_arm  NULL
 SkBlitRow::ColorProc SkBlitRow::PlatformColorProc() {
     return SK_ARM_NEON_WRAP(Color32_arm);
 }
 
+#if SK_ARM_NEON_IS_NONE
 SkBlitMask::ColorProc SkBlitMask::PlatformColorProcs(SkBitmap::Config dstConfig,

[djsollen, 2013/08/05 17:25:00]

I would either leave these functions here or move them into
SkBlitMask_opts_arm.cpp and have them import the neon header that exposes the
specific neon functions.

{
  if (sk_cpu_arm_has_neon()) {
    sk_blitmask_platform_color_procs_arm_neon(dstConfig, maskFormat, color);
  else {
    return NULL;

}

[kevin.petit.not.used.account, 2013/08/06 10:00:55]

I agree that the current version duplicates the functions which can be unclear.

If you're not bothered by the number of files I'd prefer creating
SkBlitMask_opts_arm.cpp plus SkBlitMask_opts_none.cpp and
SkBlitMask_opts_SSE2.cpp for consistency.

If you are, I'll keep these functions in SkBlitRow_opts_arm.cpp.

The choice is yours.
I'm using SK_ARM_NEON_WRAP that allows to deal with the no NEON and always NEON
cases at compile time.

                                                      SkMask::Format maskFormat,
                                                      SkColor color) {
     return NULL;
 }
 
 SkBlitMask::BlitLCD16RowProc SkBlitMask::PlatformBlitRowProcs16(bool isOpaque) {
     return NULL;
 }
 
 SkBlitMask::RowProc SkBlitMask::PlatformRowProcs(SkBitmap::Config dstConfig,
                                                  SkMask::Format maskFormat,
                                                  RowFlags flags) {
     return NULL;
 }
+#endif
+