Add Android Chromoting client keyboard input

remoting/client/jni/chromoting_jni_instance.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/client/jni/chromoting_jni_instance.h"
 
 #include "base/bind.h"
 #include "base/logging.h"
 #include "remoting/client/audio_player.h"
+#include "remoting/client/jni/android_keymap.h"
 #include "remoting/client/jni/chromoting_jni_runtime.h"
 #include "remoting/protocol/libjingle_transport_factory.h"
 
 // TODO(solb) Move into location shared with client plugin.
 const char* const CHAT_SERVER = "talk.google.com";
 const int CHAT_PORT = 5222;
 const bool CHAT_USE_TLS = true;
 
 namespace remoting {
 
@@ skipping 78 matching lines @@
   protocol::MouseEvent action;
   action.set_x(x);
   action.set_y(y);
   action.set_button(button);
   if (button != protocol::MouseEvent::BUTTON_UNDEFINED)
     action.set_button_down(buttonDown);
 
   connection_->input_stub()->InjectMouseEvent(action);
 }
 
+void ChromotingJniInstance::PerformKeyboardAction(int keyCode, bool keyDown) {
+  if (!jni_runtime_->network_task_runner()->BelongsToCurrentThread()) {
+    jni_runtime_->network_task_runner()->PostTask(
+        FROM_HERE,
+        base::Bind(&ChromotingJniInstance::PerformKeyboardAction,
+                   this,

[Sergey Ulanov, 2013/07/30 19:19:27]

two arguments below this one would fit on this line.

[solb, 2013/07/30 21:30:54]

It's formatted in accordance with
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Calls
("If the function has many arguments, consider having one per line if this makes
the code more readable.")

[Sergey Ulanov, 2013/07/30 21:42:10]

"if this makes the code more readable". IMO it doesn't make this code more
readable, particularly in this case with base::Bind() when all actual parameters
for the function fit on one line. But feel free to disagree.

+                   keyCode,
+                   keyDown));
+    return;
+  }
+
+  uint32 usbCode = AndroidKeycodeToUsbKeycode(keyCode);
+  if (usbCode) {
+    protocol::KeyEvent action;
+    action.set_usb_keycode(usbCode);
+    action.set_pressed(keyDown);
+    connection_->input_stub()->InjectKeyEvent(action);
+  }
+  else
+    LOG(WARNING) << "Ignoring unknown keycode: " << keyCode;

[Sergey Ulanov, 2013/07/30 19:19:27]

nit: add {}

[solb, 2013/07/30 21:30:54]

Done in https://codereview.chromium.org/21236002

+}
+
 void ChromotingJniInstance::OnConnectionState(
     protocol::ConnectionToHost::State state,
     protocol::ErrorCode error) {
   if (!jni_runtime_->ui_task_runner()->BelongsToCurrentThread()) {
     jni_runtime_->ui_task_runner()->PostTask(
             FROM_HERE,
             base::Bind(&ChromotingJniInstance::OnConnectionState,
                        this,
                        state,
                        error));
@@ skipping 131 matching lines @@
                    pairable,
                    callback));
     return;
   }
 
   pin_callback_ = callback;
   jni_runtime_->DisplayAuthenticationPrompt();
 }
 
 }  // namespace remoting