components/gcm_driver/gcm_desktop_utils.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/gcm_desktop_utils.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: address most of peter's concerns Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/gcm_driver/gcm_client_impl_unittest.cc ('K') | « components/gcm_driver/gcm_client_impl_unittest.cc ('k') | components/gcm_driver/gcm_desktop_utils.cc » ('j') | components/gcm_driver/gcm_desktop_utils.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/gcm_desktop_utils.h

diff --git a/components/gcm_driver/gcm_desktop_utils.h b/components/gcm_driver/gcm_desktop_utils.h

index bd8ce48ca3fcdd17ef137a1fa4a78cb221cb5c69..edc64b356ed0f6ef5814a28ed78f00b2a2e47472 100644

--- a/components/gcm_driver/gcm_desktop_utils.h

+++ b/components/gcm_driver/gcm_desktop_utils.h

@@ -20,16 +20,23 @@ namespace net {

class URLRequestContextGetter;

}

+namespace user_prefs {

+class PrefRegistrySyncable;

namespace gcm {

class GCMDriver;

class GCMClientFactory;

+void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

std::unique_ptr<GCMDriver> CreateGCMDriverDesktop(

std::unique_ptr<GCMClientFactory> gcm_client_factory,

PrefService* prefs,

const base::FilePath& store_path,

const scoped_refptr<net::URLRequestContextGetter>& request_context,

+ const std::string& product_shortname,

version_info::Channel channel,

const scoped_refptr<base::SequencedTaskRunner>& ui_task_runner,

const scoped_refptr<base::SequencedTaskRunner>& io_task_runner,