Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/gcm_driver/DEPS

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: address most of peter's concerns Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« components/gcm_driver/BUILD.gn ('K') | « components/gcm_driver/BUILD.gn ('k') | components/gcm_driver/fake_gcm_client.h » ('j') | components/gcm_driver/gcm_client.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/gcm_driver/DEPS
diff --git a/components/gcm_driver/DEPS b/components/gcm_driver/DEPS
index 8f929c44002374803ecc7cf57acbbe6b47379794..50ff51b53233a328e8f6ec7ea3e14a57eec00b35 100644
--- a/components/gcm_driver/DEPS
+++ b/components/gcm_driver/DEPS
@@ -7,8 +7,7 @@ include_rules = [
"+components/sync_driver",
"+components/timers", # Only used for Chrome OS builds.
"+components/version_info",
- # TODO(johnme): Fix this layering violation.
- "!content/public/android/java",
+ "+content/public/android/java",
"+google_apis/gaia",
"+google_apis/gcm",
"+jni",
« components/gcm_driver/BUILD.gn ('K') | « components/gcm_driver/BUILD.gn ('k') | components/gcm_driver/fake_gcm_client.h » ('j') | components/gcm_driver/gcm_client.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698