components/gcm_driver.gypi - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver.gypi

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: address most of peter's concerns Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/gcm_driver.gypi

diff --git a/components/gcm_driver.gypi b/components/gcm_driver.gypi

index 5a0b31e18315795c36e8992d9443a8f723bbbb66..15e3176e6032c23124ba74514f281e065d36e3a8 100644

--- a/components/gcm_driver.gypi

+++ b/components/gcm_driver.gypi

@@ -34,6 +34,7 @@

'../google_apis/gcm/gcm.gyp:gcm',

'../net/net.gyp:net',

'../sync/sync.gyp:sync_proto',

+ '../third_party/re2/re2.gyp:re2',

Peter Beverloo 2016/07/22 12:17:03 drop

johnme 2016/07/26 17:11:55 Oops done.

'../url/url.gyp:url_lib',

'include_dirs': [

@@ -89,6 +90,8 @@

'gcm_driver/gcm_stats_recorder_android.h',

'gcm_driver/gcm_stats_recorder_impl.cc',

'gcm_driver/gcm_stats_recorder_impl.h',

+ 'gcm_driver/pref_names.cc',

+ 'gcm_driver/pref_names.h',

'gcm_driver/registration_info.cc',

'gcm_driver/registration_info.h',

'gcm_driver/system_encryptor.cc',

@@ -119,6 +122,8 @@

'gcm_driver/gcm_driver_desktop.h',

'gcm_driver/gcm_stats_recorder_impl.cc',

'gcm_driver/gcm_stats_recorder_impl.h',

+ 'gcm_driver/pref_names.cc',

+ 'gcm_driver/pref_names.h',

}],

['chromeos == 1', {

« no previous file with comments | « chrome/browser/services/gcm/gcm_profile_service_unittest.cc ('k') | components/gcm_driver/BUILD.gn » ('j') | components/gcm_driver/BUILD.gn » ('J')