components/gcm_driver/instance_id/instance_id.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/gcm_driver/instance_id/instance_id.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Remove channel from product_category_for_subtypes, and address nits Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/gcm_driver/instance_id/fake_gcm_driver_for_instance_id.cc ('k') | components/gcm_driver/instance_id/instance_id_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/gcm_driver/instance_id/instance_id.h

diff --git a/components/gcm_driver/instance_id/instance_id.h b/components/gcm_driver/instance_id/instance_id.h

index 85536a414008b8d61d94d70d2c5f27a2ec3c14e2..52c1adb07b26dd50ecb91559e229024b5912bc5d 100644

--- a/components/gcm_driver/instance_id/instance_id.h

+++ b/components/gcm_driver/instance_id/instance_id.h

@@ -60,12 +60,12 @@ class InstanceID {

static const int kInstanceIDByteLength = 8;

- // Creator.

+ // Creator. Should only be used by InstanceIDDriver::GetInstanceID.

// |app_id|: identifies the application that uses the Instance ID.

// |handler|: provides the GCM functionality needed to support Instance ID.

// Must outlive this class. On Android, this can be null instead.

- static std::unique_ptr<InstanceID> Create(const std::string& app_id,

- gcm::GCMDriver* gcm_driver);

+ static std::unique_ptr<InstanceID> CreateInternal(const std::string& app_id,

+ gcm::GCMDriver* gcm_driver);

virtual ~InstanceID();