Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: google_apis/gcm/engine/unregistration_request.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Address jianli's review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: google_apis/gcm/engine/unregistration_request.h
diff --git a/google_apis/gcm/engine/unregistration_request.h b/google_apis/gcm/engine/unregistration_request.h
index 06e9d506bdb61dceffd71741d42eed8187a3bc92..4e58326a42a29944f94cac9cad609f5706a4823d 100644
--- a/google_apis/gcm/engine/unregistration_request.h
+++ b/google_apis/gcm/engine/unregistration_request.h
@@ -64,15 +64,22 @@ class GCM_EXPORT UnregistrationRequest : public net::URLFetcherDelegate {
struct GCM_EXPORT RequestInfo {
RequestInfo(uint64_t android_id,
uint64_t security_token,
- const std::string& app_id);
+ const std::string& category,
+ const std::string& subtype);
~RequestInfo();
// Android ID of the device.
uint64_t android_id;
// Security token of the device.
uint64_t security_token;
- // Application ID.
- std::string app_id;
+
+ // Application ID used in Chrome to refer to registration/token's owner.
+ const std::string& app_id() { return subtype.empty() ? category : subtype; }
+
+ // GCM category field derived from the |app_id|.
+ std::string category;
+ // GCM subtype field derived from the |app_id|.
+ std::string subtype;
};
// Encapsulates the custom logic that is needed to build and process the

Powered by Google App Engine
This is Rietveld 408576698