Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(604)

Unified Diff: chrome/browser/prefs/browser_prefs.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push
Patch Set: Address jianli's review comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/prefs/browser_prefs.cc
diff --git a/chrome/browser/prefs/browser_prefs.cc b/chrome/browser/prefs/browser_prefs.cc
index 64d4108cfd5cc64789b3fcb582deb9b139d5a05c..b26b8cd896a7ac4fa992fdf0ebd4b695ef85e01e 100644
--- a/chrome/browser/prefs/browser_prefs.cc
+++ b/chrome/browser/prefs/browser_prefs.cc
@@ -151,6 +151,7 @@
#endif
#if !defined(OS_ANDROID)
+#include "chrome/browser/services/gcm/gcm_product_util.h"
#include "chrome/browser/signin/signin_promo.h"
#include "chrome/browser/ui/webui/foreign_session_handler.h"
#endif
@@ -380,6 +381,7 @@ void RegisterLocalState(PrefRegistrySimple* registry) {
StartupBrowserCreator::RegisterLocalStatePrefs(registry);
// The native GCM is used on Android instead.
gcm::GCMChannelStatusSyncer::RegisterPrefs(registry);
+ gcm::RegisterPrefs(registry);
UpgradeDetector::RegisterPrefs(registry);
#if !defined(OS_CHROMEOS)
RegisterDefaultBrowserPromptPrefs(registry);
@@ -549,19 +551,22 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
extensions::ExtensionSettingsHandler::RegisterProfilePrefs(registry);
extensions::TabsCaptureVisibleTabFunction::RegisterProfilePrefs(registry);
first_run::RegisterProfilePrefs(registry);
- gcm::GCMChannelStatusSyncer::RegisterProfilePrefs(registry);
NewTabUI::RegisterProfilePrefs(registry);
PepperFlashSettingsManager::RegisterProfilePrefs(registry);
PinnedTabCodec::RegisterProfilePrefs(registry);
signin::RegisterProfilePrefs(registry);
#endif
-#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
- default_apps::RegisterProfilePrefs(registry);
-#endif
-
#if defined(OS_ANDROID)
NotificationPlatformBridgeAndroid::RegisterProfilePrefs(registry);
+#else
+ browser_sync::ForeignSessionHandler::RegisterProfilePrefs(registry);
+ gcm::GCMChannelStatusSyncer::RegisterProfilePrefs(registry);
+ gcm::RegisterProfilePrefs(registry);
+#endif
+
+#if !defined(OS_ANDROID) && !defined(OS_CHROMEOS)
+ default_apps::RegisterProfilePrefs(registry);
#endif
#if defined(OS_CHROMEOS)
@@ -599,10 +604,6 @@ void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry) {
ash::launcher::RegisterChromeLauncherUserPrefs(registry);
#endif
-#if !defined(OS_ANDROID)
- browser_sync::ForeignSessionHandler::RegisterProfilePrefs(registry);
-#endif
-
// Preferences registered only for migration (clearing or moving to a new key)
// go here.

Powered by Google App Engine
This is Rietveld 408576698