chrome/browser/browser_process_impl.cc - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/browser_process_impl.cc

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address review comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/browser_process_impl.cc

diff --git a/chrome/browser/browser_process_impl.cc b/chrome/browser/browser_process_impl.cc

index c70b4656dda08a234c22b60a4a99d8353b644fa8..25dd9b79a6de690b9ad7bed4fc7a280804e605a3 100644

--- a/chrome/browser/browser_process_impl.cc

+++ b/chrome/browser/browser_process_impl.cc

@@ -129,6 +129,7 @@

#if !defined(OS_ANDROID)

#include "chrome/browser/lifetime/keep_alive_registry.h"

+#include "chrome/browser/services/gcm/gcm_product_util.h"

#include "chrome/browser/ui/user_manager.h"

#include "components/gcm_driver/gcm_client_factory.h"

#include "components/gcm_driver/gcm_desktop_utils.h"

@@ -1181,6 +1182,7 @@ void BrowserProcessImpl::CreateGCMDriver() {

gcm_driver_ = gcm::CreateGCMDriverDesktop(

base::WrapUnique(new gcm::GCMClientFactory), local_state(), store_path,

system_request_context(), chrome::GetChannel(),

+ gcm::CategoryForSubtypes(local_state()),

Peter Beverloo 2016/07/28 12:34:09 nit: as discussed, name this method GetProductCate

johnme 2016/08/04 17:47:13 Done.

content::BrowserThread::GetTaskRunnerForThread(

content::BrowserThread::UI),

content::BrowserThread::GetTaskRunnerForThread(

« no previous file with comments | « no previous file | chrome/browser/extensions/api/instance_id/instance_id_api.cc » ('j') | chrome/browser/services/gcm/gcm_product_util.h » ('J')