chrome/browser/services/gcm/gcm_product_util.h - Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/services/gcm/gcm_product_util.h

Issue 2111973002: Add support for GCM subtypes to desktop Instance ID implementation (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@iid9push

Patch Set: Address review comments Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« chrome/browser/browser_process_impl.cc ('K') | « chrome/browser/prefs/browser_prefs.cc ('k') | chrome/browser/services/gcm/gcm_product_util.cc » ('j') | chrome/browser/services/gcm/gcm_product_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_SERVICES_GCM_GCM_PRODUCT_UTIL_H_

	6 #define CHROME_BROWSER_SERVICES_GCM_GCM_PRODUCT_UTIL_H_

	7

	8 #include <string>

	9

	10 class PrefService;

	11

	12 namespace user_prefs {

	13 class PrefRegistrySyncable;

	14 }

	15

	16 namespace gcm {

	17

	18 std::string CategoryForSubtypes(PrefService* prefs);
	Peter Beverloo 2016/07/28 12:34:09 nit: document the method here, not in the implemen nit: document the method here, not in the implementation file johnme 2016/08/04 17:47:14 Done. Show quoted text On 2016/07/28 12:34:09, Peter Beverloo wrote: > nit: document the method here, not in the implementation file Done.
	19

	20 void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);

	21

	22 } // namespace gcm

	23

	24 #endif // CHROME_BROWSER_SERVICES_GCM_GCM_PRODUCT_UTIL_H_

OLD	NEW