Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Issue 2111953002: Minor test cleanup. (Closed)

Created:
4 years, 5 months ago by Bence
Modified:
4 years, 5 months ago
Reviewers:
Ryan Hamilton
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Minor test cleanup. * Change SpdyHttpStreamTest SpdySessionKey port from 80 to 443. * In SpdyHttpStreamTest, BidirectionalStreamTest, and BidirectionalStreamSpdyImplTest, add GURL, HostPortPair, and SpdySessionKey members, and remove SdySessionKey argument from InitSession, for brevity. * Add GURL member to HttpStreamFactoryBidirectionalQuicTest for brevity. * Use kDefaultUrl instead of "https://www.example.org" in a whole bunch of tests. Committed: https://crrev.com/3d9035b35e7ddb825495f2d9e60f4b6454d55cd2 Cr-Commit-Position: refs/heads/master@{#403225}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+133 lines, -221 lines) Patch
M net/http/bidirectional_stream_unittest.cc View 35 chunks +55 lines, -95 lines 0 comments Download
M net/http/http_stream_factory_impl_unittest.cc View 11 chunks +10 lines, -14 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 8 chunks +17 lines, -23 lines 0 comments Download
M net/spdy/bidirectional_stream_spdy_impl_unittest.cc View 7 chunks +14 lines, -15 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 33 chunks +37 lines, -74 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Bence
Ryan: PTAL. Thank you.
4 years, 5 months ago (2016-06-30 17:52:12 UTC) #2
Ryan Hamilton
lgtm nice!
4 years, 5 months ago (2016-06-30 18:08:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111953002/1
4 years, 5 months ago (2016-06-30 18:13:00 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 18:19:22 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 18:19:26 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 18:25:44 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/3d9035b35e7ddb825495f2d9e60f4b6454d55cd2
Cr-Commit-Position: refs/heads/master@{#403225}

Powered by Google App Engine
This is Rietveld 408576698