src/interpreter/bytecodes.h - Issue 2111923002: [interpreter] Introduce binary op bytecodes for Smi operand.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecodes.h

Issue 2111923002: [interpreter] Introduce binary op bytecodes for Smi operand. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Tweak a name. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« src/interpreter/bytecode-peephole-optimizer.cc ('K') | « src/interpreter/bytecode-pipeline.cc ('k') | src/interpreter/interpreter.h » ('j') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/interpreter/bytecodes.h

diff --git a/src/interpreter/bytecodes.h b/src/interpreter/bytecodes.h

index 556e0b0195c8884105319b955164ff5b916f1c82..ac79c75856b8f04e71f032c6ae51f13cf876042e 100644

--- a/src/interpreter/bytecodes.h

+++ b/src/interpreter/bytecodes.h

@@ -157,6 +157,18 @@ namespace interpreter {

V(ShiftRight, AccumulatorUse::kReadWrite, OperandType::kReg) \

V(ShiftRightLogical, AccumulatorUse::kReadWrite, OperandType::kReg) \

+ /* Binary operators with immediate operands */ \

+ V(AddSmi, AccumulatorUse::kWrite, OperandType::kImm, OperandType::kReg) \

+ V(SubSmi, AccumulatorUse::kWrite, OperandType::kImm, OperandType::kReg) \

+ V(BitwiseOrSmi, AccumulatorUse::kWrite, OperandType::kImm, \

+ OperandType::kReg) \

+ V(BitwiseAndSmi, AccumulatorUse::kWrite, OperandType::kImm, \

+ OperandType::kReg) \

+ V(ShiftLeftSmi, AccumulatorUse::kWrite, OperandType::kImm, \

+ OperandType::kReg) \

+ V(ShiftRightSmi, AccumulatorUse::kWrite, OperandType::kImm, \

+ OperandType::kReg) \

+ \

/* Unary Operators */ \

V(Inc, AccumulatorUse::kReadWrite) \

V(Dec, AccumulatorUse::kReadWrite) \