Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(495)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden

Issue 2111923002: [interpreter] Introduce binary op bytecodes for Smi operand. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Document handlers in interpreter.cc Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« src/interpreter/interpreter.cc ('K') | « test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
diff --git a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
index 3d6e641bc23665e8c73805eab5b022eec63f2777..463c8a06b0e16ea705e07a9f7d6ec6442aaf730a 100644
--- a/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
+++ b/test/cctest/interpreter/bytecode_expectations/BasicLoops.golden
@@ -65,7 +65,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 48
+bytecode array length: 47
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -74,13 +74,12 @@ bytecodes: [
B(Star), R(1),
/* 65 S> */ B(LdaSmi), U8(10),
/* 65 E> */ B(TestLessThan), R(0),
- B(JumpIfFalse), U8(33),
+ B(JumpIfFalse), U8(32),
/* 56 E> */ B(StackCheck),
/* 75 S> */ B(LdaSmi), U8(12),
B(Mul), R(1),
B(Star), R(1),
- /* 89 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 89 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 102 S> */ B(LdaSmi), U8(3),
/* 108 E> */ B(TestEqual), R(0),
@@ -90,7 +89,7 @@ bytecodes: [
/* 132 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
/* 138 S> */ B(Jump), U8(4),
- B(Jump), U8(-35),
+ B(Jump), U8(-34),
/* 147 S> */ B(Ldar), R(1),
/* 157 S> */ B(Return),
]
@@ -114,7 +113,7 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 55
+bytecode array length: 54
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -123,27 +122,26 @@ bytecodes: [
/* 62 S> */ B(LdaZero),
/* 68 E> */ B(TestLessThan), R(0),
B(JumpIfFalse), U8(4),
- /* 73 S> */ B(Jump), U8(40),
+ /* 73 S> */ B(Jump), U8(39),
/* 85 S> */ B(LdaSmi), U8(3),
/* 91 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 97 S> */ B(Jump), U8(34),
+ /* 97 S> */ B(Jump), U8(33),
/* 106 S> */ B(LdaSmi), U8(4),
/* 112 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 118 S> */ B(Jump), U8(26),
+ /* 118 S> */ B(Jump), U8(25),
/* 127 S> */ B(LdaSmi), U8(10),
/* 133 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 140 S> */ B(Jump), U8(16),
+ /* 140 S> */ B(Jump), U8(15),
/* 152 S> */ B(LdaSmi), U8(5),
/* 158 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 164 S> */ B(Jump), U8(10),
- /* 173 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 164 S> */ B(Jump), U8(9),
+ /* 173 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-46),
+ B(Jump), U8(-45),
/* 186 S> */ B(Ldar), R(0),
/* 196 S> */ B(Return),
]
@@ -167,7 +165,7 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 41
+bytecode array length: 39
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -175,21 +173,19 @@ bytecodes: [
/* 45 E> */ B(StackCheck),
/* 71 S> */ B(LdaSmi), U8(3),
/* 71 E> */ B(TestLessThan), R(0),
- B(JumpIfFalse), U8(19),
+ B(JumpIfFalse), U8(18),
/* 62 E> */ B(StackCheck),
/* 82 S> */ B(LdaSmi), U8(2),
/* 88 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 94 S> */ B(Jump), U8(10),
- /* 105 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 94 S> */ B(Jump), U8(9),
+ /* 105 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-21),
- /* 122 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ B(Jump), U8(-20),
+ /* 122 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 135 S> */ B(Jump), U8(4),
- B(Jump), U8(-32),
+ B(Jump), U8(-30),
/* 144 S> */ B(Ldar), R(0),
/* 154 S> */ B(Return),
]
@@ -210,7 +206,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 31
+bytecode array length: 30
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(10),
@@ -218,15 +214,14 @@ bytecodes: [
/* 54 S> */ B(LdaSmi), U8(1),
B(Star), R(1),
/* 64 S> */ B(Ldar), R(0),
- B(JumpIfToBooleanFalse), U8(17),
+ B(JumpIfToBooleanFalse), U8(16),
/* 57 E> */ B(StackCheck),
/* 71 S> */ B(LdaSmi), U8(12),
B(Mul), R(1),
B(Star), R(1),
- /* 85 S> */ B(LdaSmi), U8(1),
- B(Sub), R(0),
+ /* 85 S> */ B(SubSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-17),
+ B(Jump), U8(-16),
/* 98 S> */ B(Ldar), R(1),
/* 108 S> */ B(Return),
]
@@ -248,7 +243,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 46
+bytecode array length: 45
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -262,17 +257,16 @@ bytecodes: [
/* 77 S> */ B(LdaSmi), U8(5),
/* 83 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(22),
+ /* 89 S> */ B(Jump), U8(21),
/* 98 S> */ B(LdaSmi), U8(6),
/* 104 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 110 S> */ B(Jump), U8(8),
- /* 122 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 110 S> */ B(Jump), U8(7),
+ /* 122 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 144 S> */ B(LdaSmi), U8(10),
/* 144 E> */ B(TestLessThan), R(0),
- B(JumpIfTrue), U8(-33),
+ B(JumpIfTrue), U8(-32),
/* 151 S> */ B(Ldar), R(1),
/* 161 S> */ B(Return),
]
@@ -293,7 +287,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 29
+bytecode array length: 28
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaSmi), U8(10),
@@ -304,11 +298,10 @@ bytecodes: [
/* 64 S> */ B(LdaSmi), U8(12),
B(Mul), R(1),
B(Star), R(1),
- /* 78 S> */ B(LdaSmi), U8(1),
- B(Sub), R(0),
+ /* 78 S> */ B(SubSmi), U8(1), R(0),
B(Star), R(0),
/* 98 S> */ B(Ldar), R(0),
- B(JumpIfToBooleanTrue), U8(-15),
+ B(JumpIfToBooleanTrue), U8(-14),
/* 102 S> */ B(Ldar), R(1),
/* 112 S> */ B(Return),
]
@@ -330,7 +323,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 40
+bytecode array length: 39
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -344,9 +337,8 @@ bytecodes: [
/* 77 S> */ B(LdaSmi), U8(5),
/* 83 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(16),
- /* 98 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 89 S> */ B(Jump), U8(15),
+ /* 98 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 111 S> */ B(LdaSmi), U8(6),
/* 117 E> */ B(TestEqual), R(0),
@@ -373,7 +365,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 42
+bytecode array length: 41
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -387,15 +379,14 @@ bytecodes: [
/* 77 S> */ B(LdaSmi), U8(5),
/* 83 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(18),
- /* 98 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 89 S> */ B(Jump), U8(17),
+ /* 98 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 111 S> */ B(LdaSmi), U8(6),
/* 117 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
/* 123 S> */ B(Jump), U8(2),
- B(Jump), U8(-29),
+ B(Jump), U8(-28),
/* 149 S> */ B(Ldar), R(1),
/* 159 S> */ B(Return),
]
@@ -415,7 +406,7 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 30
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -424,15 +415,14 @@ bytecodes: [
/* 58 S> */ B(LdaSmi), U8(1),
/* 64 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 70 S> */ B(Jump), U8(18),
+ /* 70 S> */ B(Jump), U8(17),
/* 79 S> */ B(LdaSmi), U8(2),
/* 85 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 91 S> */ B(Jump), U8(8),
- /* 103 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 91 S> */ B(Jump), U8(7),
+ /* 103 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-22),
B(LdaUndefined),
/* 116 S> */ B(Return),
]
@@ -451,7 +441,7 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 30
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 47 S> */ B(LdaZero),
@@ -460,15 +450,14 @@ bytecodes: [
/* 56 S> */ B(LdaSmi), U8(1),
/* 62 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 68 S> */ B(Jump), U8(18),
+ /* 68 S> */ B(Jump), U8(17),
/* 77 S> */ B(LdaSmi), U8(2),
/* 83 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 89 S> */ B(Jump), U8(8),
- /* 101 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 89 S> */ B(Jump), U8(7),
+ /* 101 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-22),
B(LdaUndefined),
/* 114 S> */ B(Return),
]
@@ -487,7 +476,7 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 30
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -496,15 +485,14 @@ bytecodes: [
/* 68 S> */ B(LdaSmi), U8(1),
/* 74 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 80 S> */ B(Jump), U8(18),
+ /* 80 S> */ B(Jump), U8(17),
/* 89 S> */ B(LdaSmi), U8(2),
/* 95 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
/* 101 S> */ B(Jump), U8(2),
- /* 55 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 55 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-22),
B(LdaUndefined),
/* 113 S> */ B(Return),
]
@@ -522,7 +510,7 @@ snippet: "
"
frame size: 1
parameter count: 1
-bytecode array length: 31
+bytecode array length: 30
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 47 S> */ B(LdaZero),
@@ -531,15 +519,14 @@ bytecodes: [
/* 66 S> */ B(LdaSmi), U8(1),
/* 72 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
- /* 78 S> */ B(Jump), U8(18),
+ /* 78 S> */ B(Jump), U8(17),
/* 87 S> */ B(LdaSmi), U8(2),
/* 93 E> */ B(TestEqual), R(0),
B(JumpIfFalse), U8(4),
/* 99 S> */ B(Jump), U8(2),
- /* 53 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 53 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
- B(Jump), U8(-23),
+ B(Jump), U8(-22),
B(LdaUndefined),
/* 111 S> */ B(Return),
]
@@ -558,7 +545,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 32
+bytecode array length: 30
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -567,16 +554,14 @@ bytecodes: [
B(Star), R(1),
/* 63 S> */ B(LdaSmi), U8(100),
/* 63 E> */ B(TestLessThan), R(1),
- B(JumpIfFalse), U8(19),
+ B(JumpIfFalse), U8(17),
/* 45 E> */ B(StackCheck),
- /* 85 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 85 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 98 S> */ B(Jump), U8(2),
- /* 72 S> */ B(LdaSmi), U8(1),
- B(Add), R(1),
+ /* 72 S> */ B(AddSmi), U8(1), R(1),
B(Star), R(1),
- B(Jump), U8(-21),
+ B(Jump), U8(-19),
B(LdaUndefined),
/* 110 S> */ B(Return),
]
@@ -656,7 +641,7 @@ snippet: "
"
frame size: 2
parameter count: 1
-bytecode array length: 32
+bytecode array length: 31
bytecodes: [
/* 30 E> */ B(StackCheck),
/* 42 S> */ B(LdaZero),
@@ -664,8 +649,7 @@ bytecodes: [
/* 58 S> */ B(LdaZero),
B(Star), R(1),
/* 45 E> */ B(StackCheck),
- /* 76 S> */ B(LdaSmi), U8(1),
- B(Add), R(0),
+ /* 76 S> */ B(AddSmi), U8(1), R(0),
B(Star), R(0),
/* 89 S> */ B(LdaSmi), U8(20),
/* 95 E> */ B(TestEqual), R(0),
@@ -674,7 +658,7 @@ bytecodes: [
/* 69 S> */ B(Ldar), R(1),
B(Inc),
B(Star), R(1),
- B(Jump), U8(-20),
+ B(Jump), U8(-19),
/* 112 S> */ B(Ldar), R(0),
/* 122 S> */ B(Return),
]
« src/interpreter/interpreter.cc ('K') | « test/cctest/interpreter/bytecode_expectations/AssignmentsInBinaryExpression.golden ('k') | test/cctest/interpreter/bytecode_expectations/BreakableBlocks.golden » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698