Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issue 2111913004: Fix build dependence for data_reduction_proxy (Closed)

Created:
4 years, 5 months ago by gambard
Modified:
4 years, 5 months ago
Reviewers:
sdefresne
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix build dependence for data_reduction_proxy This CL fixes a dependence problem for building data_reduction_proxy with gyp. BUG=625030 Committed: https://crrev.com/1ec6ed740a07768d0bbcb70605b576fea4edb8e7 Cr-Commit-Position: refs/heads/master@{#403445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/data_reduction_proxy.gypi View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
gambard
4 years, 5 months ago (2016-07-01 12:47:31 UTC) #2
sdefresne
On 2016/07/01 12:47:31, gambard wrote: Can you send to the bots?
4 years, 5 months ago (2016-07-01 12:52:18 UTC) #3
sdefresne
lgtm lgtm if the bots are happy
4 years, 5 months ago (2016-07-01 12:56:51 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111913004/1
4 years, 5 months ago (2016-07-01 13:18:05 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-01 13:25:19 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-01 13:28:20 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1ec6ed740a07768d0bbcb70605b576fea4edb8e7
Cr-Commit-Position: refs/heads/master@{#403445}

Powered by Google App Engine
This is Rietveld 408576698