Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(65)

Issue 2111913002: Point to the new fdlibm license file in v8 (Closed)

Created:
4 years, 5 months ago by mvstanton
Modified:
4 years, 5 months ago
Reviewers:
Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Point to the new location of the fdlibm license file in v8. The old file still exists until this change is in. BUG= Committed: https://crrev.com/8949ae4c5c05fe1796550990ed1aa555dface90e Cr-Commit-Position: refs/heads/master@{#403668}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/licenses.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
mvstanton
Hi Pavel, We changed from a javascript fdlibm implementation to C, and moved the license ...
4 years, 5 months ago (2016-07-01 11:01:55 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-07-04 10:38:45 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111913002/1
4 years, 5 months ago (2016-07-04 11:24:32 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-04 12:06:13 UTC) #10
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-04 12:06:19 UTC) #11
commit-bot: I haz the power
4 years, 5 months ago (2016-07-04 12:08:10 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8949ae4c5c05fe1796550990ed1aa555dface90e
Cr-Commit-Position: refs/heads/master@{#403668}

Powered by Google App Engine
This is Rietveld 408576698