Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2111863002: [Autofill] Debounce suggestions poll user actions for the same field. (Closed)

Created:
4 years, 5 months ago by sebsg
Modified:
4 years, 5 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, browser-components-watch_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

A lot of suggestions poll a recorded making the analysis difficult. Record only one poll action if the same field is queried for suggestions multiple times consecutively. BUG=624753 Committed: https://crrev.com/c8bac8709c3259854ed1d4fcef5dd7e8661a2361 Cr-Commit-Position: refs/heads/master@{#403160}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+137 lines, -10 lines) Patch
M components/autofill/core/browser/autofill_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics.h View 3 chunks +5 lines, -1 line 0 comments Download
M components/autofill/core/browser/autofill_metrics.cc View 1 chunk +16 lines, -7 lines 0 comments Download
M components/autofill/core/browser/autofill_metrics_unittest.cc View 1 chunk +114 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (9 generated)
sebsg
Hi Math, could you please take a look? Thanks!
4 years, 5 months ago (2016-06-30 11:22:45 UTC) #7
Mathieu
lgtm
4 years, 5 months ago (2016-06-30 12:12:19 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111863002/80001
4 years, 5 months ago (2016-06-30 12:20:53 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:80001)
4 years, 5 months ago (2016-06-30 13:06:03 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 13:07:12 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c8bac8709c3259854ed1d4fcef5dd7e8661a2361
Cr-Commit-Position: refs/heads/master@{#403160}

Powered by Google App Engine
This is Rietveld 408576698