Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2111853002: Revert of Update V8 to version 5.3.336. (Closed)

Created:
4 years, 5 months ago by Sami
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Update V8 to version 5.3.336. (patchset #1 id:1 of https://codereview.chromium.org/2104893006/ ) Reason for revert: Causing crashes on the perf waterfall (see bug for logs): Received signal 11 SEGV_MAPERR 000000000010 #0 0x7f3bf49793b7 base::debug::(anonymous namespace)::StackDumpSignalHandler() #1 0x7f3bf46b9330 <unknown> #2 0x7f3bf0c84899 v8::internal::compiler::GraphTrimmer::TrimGraph() #3 0x7f3bf0ce9c8e v8::internal::compiler::EffectControlLinearizationPhase::Run() #4 0x7f3bf0ce399b v8::internal::compiler::PipelineImpl::OptimizeGraph() #5 0x7f3bf0ce3904 v8::internal::compiler::PipelineCompilationJob::OptimizeGraphImpl() #6 0x7f3bf0c3acd8 v8::internal::CompilationJob::OptimizeGraph() #7 0x7f3bf0f6ec18 v8::internal::OptimizingCompileDispatcher::CompileNext() #8 0x7f3bf0f6f645 v8::internal::OptimizingCompileDispatcher::CompileTask::Run() #9 0x7f3bf49edaa7 base::(anonymous namespace)::WorkerThread::ThreadMain() #10 0x7f3bf49e5b13 base::(anonymous namespace)::ThreadFunc() BUG=624463 Original issue's description: > Update V8 to version 5.3.336. > > Summary of changes available at: > https://chromium.googlesource.com/v8/v8/+log/81ce7501..e1fa935d > > Please follow these instructions for assigning/CC'ing issues: > https://github.com/v8/v8/wiki/Triaging%20issues > > Please close rolling in case of a roll revert: > https://v8-roll.appspot.com/ > This only works with a Google account. > > CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel > > TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org > > Committed: https://crrev.com/1a92fc945f648e9d787dda5c247cdfea088b6d65 > Cr-Commit-Position: refs/heads/master@{#402773} TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/0d4110d82c8b9c3d743aa6d14e63ca5aaec0c241 Cr-Commit-Position: refs/heads/master@{#403133}

Patch Set 1 #

Patch Set 2 : Fixed revert #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
Sami
Created Revert of Update V8 to version 5.3.336.
4 years, 5 months ago (2016-06-30 09:41:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111853002/1
4 years, 5 months ago (2016-06-30 09:42:09 UTC) #3
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-06-30 09:42:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111853002/40001
4 years, 5 months ago (2016-06-30 09:45:34 UTC) #7
commit-bot: I haz the power
Failed to apply patch for DEPS: While running git apply --index -3 -p1; error: patch ...
4 years, 5 months ago (2016-06-30 09:46:00 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 09:46:07 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111853002/60001
4 years, 5 months ago (2016-06-30 09:49:44 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:60001)
4 years, 5 months ago (2016-06-30 09:50:20 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 09:52:01 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/0d4110d82c8b9c3d743aa6d14e63ca5aaec0c241
Cr-Commit-Position: refs/heads/master@{#403133}

Powered by Google App Engine
This is Rietveld 408576698