Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 2111843002: [wasm] Fix receiver conversion for WASM->JS calls. (Closed)

Created:
4 years, 5 months ago by titzer
Modified:
4 years, 5 months ago
Reviewers:
ahaas, Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Fix receiver conversion for WASM->JS calls. R=yangguo@chromium.org,ahaas@chromium.org BUG=chromium:624713 LOG=Y Committed: https://crrev.com/971731f354842236f3643b7f771f8aac89ac2ef3 Cr-Commit-Position: refs/heads/master@{#37428}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -5 lines) Patch
M src/compiler/wasm-compiler.cc View 1 chunk +6 lines, -3 lines 0 comments Download
M test/mjsunit/wasm/import-table.js View 2 chunks +2 lines, -2 lines 0 comments Download
A test/mjsunit/wasm/receiver.js View 1 chunk +45 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
titzer
4 years, 5 months ago (2016-06-30 09:12:29 UTC) #1
ahaas
lgtm
4 years, 5 months ago (2016-06-30 09:18:51 UTC) #2
Yang
On 2016/06/30 09:18:51, ahaas wrote: > lgtm lgtm.
4 years, 5 months ago (2016-06-30 09:20:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111843002/1
4 years, 5 months ago (2016-06-30 09:22:08 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 09:40:39 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 09:40:40 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 09:41:56 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/971731f354842236f3643b7f771f8aac89ac2ef3
Cr-Commit-Position: refs/heads/master@{#37428}

Powered by Google App Engine
This is Rietveld 408576698