Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2111803003: DBC: Remove special case from CheckClassInstr. Cleanup. (Closed)

Created:
4 years, 5 months ago by zra
Modified:
4 years, 5 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

DBC: Remove special case from CheckClassInstr. Cleanup. R=vegorov@google.com Committed: https://github.com/dart-lang/sdk/commit/1c783dea87675a0e65e780f64de17258ff82ce4f

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -47 lines) Patch
M runtime/vm/flow_graph_compiler.h View 1 chunk +2 lines, -0 lines 2 comments Download
M runtime/vm/flow_graph_compiler_dbc.cc View 2 chunks +11 lines, -0 lines 0 comments Download
M runtime/vm/il_printer.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.h View 1 chunk +2 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M runtime/vm/intermediate_language_dbc.cc View 5 chunks +14 lines, -47 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
zra
4 years, 5 months ago (2016-06-30 16:53:44 UTC) #2
Vyacheslav Egorov (Google)
lgtm https://codereview.chromium.org/2111803003/diff/1/runtime/vm/flow_graph_compiler.h File runtime/vm/flow_graph_compiler.h (right): https://codereview.chromium.org/2111803003/diff/1/runtime/vm/flow_graph_compiler.h#newcode536 runtime/vm/flow_graph_compiler.h:536: uint16_t ToEmbeddableCid(intptr_t cid, Instruction* instruction); Please add a ...
4 years, 5 months ago (2016-07-01 16:18:04 UTC) #3
zra
Committed patchset #1 (id:1) manually as 1c783dea87675a0e65e780f64de17258ff82ce4f (presubmit successful).
4 years, 5 months ago (2016-07-01 17:19:25 UTC) #5
zra
4 years, 5 months ago (2016-07-01 17:20:05 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/2111803003/diff/1/runtime/vm/flow_graph_compi...
File runtime/vm/flow_graph_compiler.h (right):

https://codereview.chromium.org/2111803003/diff/1/runtime/vm/flow_graph_compi...
runtime/vm/flow_graph_compiler.h:536: uint16_t ToEmbeddableCid(intptr_t cid,
Instruction* instruction);
On 2016/07/01 16:18:03, Vyacheslav Egorov (Google) wrote:
> Please add a comment explaining what embeddable means (e.g. that you are
> truncating to 16 bits)

Done.

Powered by Google App Engine
This is Rietveld 408576698