Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Issue 2111743002: Add two memory usage benchmarks (Closed)

Created:
4 years, 5 months ago by Brian Wilkerson
Modified:
4 years, 5 months ago
Reviewers:
pquitslund, scheglov
CC:
reviews_dartlang.org, scheglov
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -4 lines) Patch
M pkg/analysis_server/benchmark/perf/benchmark_local.dart View 3 chunks +33 lines, -0 lines 1 comment Download
A pkg/analysis_server/benchmark/perf/memory_tests.dart View 1 chunk +125 lines, -0 lines 1 comment Download
M pkg/analysis_server/test/integration/analysis/highlights_test2.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/analysis_server/test/integration/integration_tests.dart View 4 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Brian Wilkerson
4 years, 5 months ago (2016-06-29 23:42:38 UTC) #2
pquitslund
lgtm
4 years, 5 months ago (2016-06-29 23:49:21 UTC) #3
Brian Wilkerson
Committed patchset #1 (id:1) manually as f3dc748db533d6533a1effd35f8ccbf217910d63 (presubmit successful).
4 years, 5 months ago (2016-06-30 14:44:43 UTC) #5
scheglov
4 years, 5 months ago (2016-07-06 17:55:04 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/2111743002/diff/1/pkg/analysis_server/benchma...
File pkg/analysis_server/benchmark/perf/benchmark_local.dart (right):

https://codereview.chromium.org/2111743002/diff/1/pkg/analysis_server/benchma...
pkg/analysis_server/benchmark/perf/benchmark_local.dart:234: 1. Start server,
set 'analyzer' and 'analysis_server' analysis roots.
I as can see, we set only "analyzer" as the analysis root.

https://codereview.chromium.org/2111743002/diff/1/pkg/analysis_server/benchma...
File pkg/analysis_server/benchmark/perf/memory_tests.dart (right):

https://codereview.chromium.org/2111743002/diff/1/pkg/analysis_server/benchma...
pkg/analysis_server/benchmark/perf/memory_tests.dart:101: *  4. Record the time
to finish analysis.
Record the heap size after analysis is finished?

Powered by Google App Engine
This is Rietveld 408576698