Perform tlslite 0.3.8 -> 0.4.6 renames ahead of time.

net/test/python_utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/python_utils.h"
 
 #include "base/base_paths.h"
 #include "base/command_line.h"
 #include "base/environment.h"
 #include "base/file_util.h"
@@ skipping 102 matching lines @@
   // This permits finding the proper python in path even if it is a .bat file.
   python_cmd->SetProgram(base::FilePath(FILE_PATH_LITERAL("cmd.exe")));
   python_cmd->AppendArg("/c");
   python_cmd->AppendArg("python");
 #else
   python_cmd->SetProgram(base::FilePath(FILE_PATH_LITERAL("python")));
 #endif  // defined(OS_WIN)
   // Launch python in unbuffered mode, so that python output doesn't mix with
   // gtest output in buildbot log files. See http://crbug.com/147368.
   python_cmd->AppendArg("-u");
+  // Don't generate .pyc files. This avoids future problems if upstreams for our
+  // bundled libraries rename more files. See http://crbug.com/356276
+  python_cmd->AppendArg("-B");

[Ryan Sleevi, 2014/03/31 19:42:14]

Someone from infra should review this change - as well as the performance
implications for try cycles.

[Peter Mayo (wrong one), 2014/04/03 21:16:30]

I certainly don't want to see this (independent) change mixed with the rest of
this CL.

I would want to be able to revert it separately should it have surprising
consequences.
I also think we have better ways to solve the particular problem.

[davidben, 2014/04/03 21:29:33]

What are the better ways we have? It's a problem right now for the CL intended
to follow after this one, -B or no. Barring other options, I'm planning on
adding this hack to the top of the test server. What would you suggest instead?

https://codereview.chromium.org/210323002/diff/1260001/net/tools/testserver/t...

Should the -B still happen? If so, it'll want to happen before this CL. The -B
is not going to solve the hmac.pyc problem; both the bots and dev checkouts
already have hmac.pyc files and unless some mechanism to clear them on both as
part of the follow-on CL already exists, I don't see a way around the os.rename.

The goal of the -B is to ensure we have no future instances of this. That's why
it's not actually independent; the point is to do it now when I'm adding (well,
renaming) files so that no new pycs spring up.

I can land it separately and extending my yak chain by one. I can also just drop
it altogether because, like I said, I have to deal with hmac.pyc no matter what.
But not including -B means banking on the better mechanism existing by the time
this problem crops up again.

For what it's worth, depot_tools seems to pretty consistently set
PYTHONDONTWRITEBYTECODE=1 which is the environment variable version of -B. So
there is some precedence.

Preferences?

 
   return true;
 }