Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Issue 2111683002: Remove mac condition for component target types. (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Robert Sesek
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove mac condition for component target types. The limitation that static libraries can't be used in various targets on Mac has been lifted. Now components can unconditionally be static libraries on non-component builds. BUG=618797 Committed: https://crrev.com/b8adea3236abf4f866ea1265e279d5520b8a9fd0 Cr-Commit-Position: refs/heads/master@{#403974}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M build/config/BUILDCONFIG.gn View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
brettw
4 years, 5 months ago (2016-06-29 22:03:54 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111683002/1
4 years, 5 months ago (2016-06-29 22:07:40 UTC) #4
Robert Sesek
LGTM
4 years, 5 months ago (2016-06-29 22:14:00 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/252733)
4 years, 5 months ago (2016-06-29 22:43:09 UTC) #7
Robert Sesek
Should be good to land this now.
4 years, 5 months ago (2016-07-06 16:37:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111683002/1
4 years, 5 months ago (2016-07-06 20:42:11 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-06 23:28:32 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-06 23:29:00 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-06 23:30:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b8adea3236abf4f866ea1265e279d5520b8a9fd0
Cr-Commit-Position: refs/heads/master@{#403974}

Powered by Google App Engine
This is Rietveld 408576698