Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issue 2111673006: Revert of Eliminate the ChannelMojo channel for renderers (Closed)

Created:
4 years, 5 months ago by Ken Rockot(use gerrit already)
Modified:
4 years, 5 months ago
CC:
chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, jam, nasko+codewatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Eliminate the ChannelMojo channel for renderers (patchset #4 id:60001 of https://codereview.chromium.org/2109043002/ ) Reason for revert: http://crbug.com/624556 Original issue's description: > Eliminate the ChannelMojo channel for renderers, instead obtain Bootstrap interface from child connection. > > R=rockot@chromium.org > http://crbug.com/623396 > > BUG= > > Committed: https://crrev.com/9e883c385ccc47607a9341d618678b35195cc8fe > Cr-Commit-Position: refs/heads/master@{#402812} TBR=ben@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG= Committed: https://crrev.com/b44da081cde654f070a29ececea36b33214a7c5e Cr-Commit-Position: refs/heads/master@{#403205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -36 lines) Patch
M content/browser/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 4 chunks +8 lines, -5 lines 0 comments Download
M content/child/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M content/child/child_thread_impl.h View 3 chunks +0 lines, -5 lines 0 comments Download
M content/child/child_thread_impl.cc View 3 chunks +6 lines, -22 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +0 lines, -1 line 0 comments Download
M content/content_child.gypi View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 9 (4 generated)
Ken Rockot(use gerrit already)
Created Revert of Eliminate the ChannelMojo channel for renderers
4 years, 5 months ago (2016-06-30 16:08:39 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111673006/1
4 years, 5 months ago (2016-06-30 16:09:20 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-30 17:19:08 UTC) #4
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 17:19:19 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-06-30 17:22:15 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b44da081cde654f070a29ececea36b33214a7c5e
Cr-Commit-Position: refs/heads/master@{#403205}

Powered by Google App Engine
This is Rietveld 408576698