Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Issue 2111673004: When autoplay of muted videos is disabled, record the reason why. (Closed)

Created:
4 years, 5 months ago by mlamouri (slow - plz ping)
Modified:
4 years, 3 months ago
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink, eric.carlson_apple.com, feature-media-reviews_chromium.org, fs, gasubic, mlamouri+watch-blink_chromium.org, nessy, vcarbune.chromium
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When autoplay of muted videos is disabled, record the reason why. BUG=622716 Committed: https://crrev.com/da304c86a66cb506e5a907631f4103078ac2cc5f Cr-Commit-Position: refs/heads/master@{#414453}

Patch Set 1 #

Patch Set 2 : rebase - not working #

Patch Set 3 : rebase #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -0 lines) Patch
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.h View 1 1 chunk +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp View 1 2 3 chunks +17 lines, -0 lines 2 comments Download
M third_party/WebKit/Source/core/html/HTMLMediaElement.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 2 chunks +16 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111673004/1
4 years, 5 months ago (2016-06-30 15:06:39 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/194823)
4 years, 5 months ago (2016-06-30 15:52:27 UTC) #4
mlamouri (slow - plz ping)
4 years, 4 months ago (2016-08-10 13:58:44 UTC) #5
mlamouri (slow - plz ping)
isherman@, PTAL at tools/metrics/ zqzhang@, PTAL at everything else Thanks :)
4 years, 4 months ago (2016-08-24 16:21:29 UTC) #8
Zhiqiang Zhang (Slow)
lgtm w/ nits Maybe we should use Member<HTMLMediaElement> again in AutoplayUmaHelper if it doesn't cause ...
4 years, 4 months ago (2016-08-24 16:50:47 UTC) #10
mlamouri (slow - plz ping)
https://codereview.chromium.org/2111673004/diff/40001/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp File third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp (right): https://codereview.chromium.org/2111673004/diff/40001/third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp#newcode69 third_party/WebKit/Source/core/html/AutoplayUmaHelper.cpp:69: blockedMutedVideoHistogram.count(AutoplayBlockedReasonDataSaverAndSetting); On 2016/08/24 at 16:50:47, Zhiqiang Zhang wrote: > ...
4 years, 4 months ago (2016-08-24 21:39:24 UTC) #13
Ilya Sherman
metrics lgtm
4 years, 4 months ago (2016-08-24 21:47:37 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111673004/40001
4 years, 3 months ago (2016-08-25 14:57:46 UTC) #16
commit-bot: I haz the power
4 years, 3 months ago (2016-08-25 16:33:40 UTC) #18
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/da304c86a66cb506e5a907631f4103078ac2cc5f
Cr-Commit-Position: refs/heads/master@{#414453}

Powered by Google App Engine
This is Rietveld 408576698