Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 2111673003: [release] Include more gpu trybots on v8 rolls (Closed)

Created:
4 years, 5 months ago by Michael Achenbach
Modified:
4 years, 5 months ago
CC:
v8-reviews_googlegroups.com, tandrii(chromium)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[release] Include more gpu trybots on v8 rolls BUG=v8:5159 NOTRY=true Committed: https://crrev.com/eb2a84d26fc62636b518d34a56559b25bd91be63 Cr-Commit-Position: refs/heads/master@{#37444}

Patch Set 1 #

Total comments: 1

Patch Set 2 : Correct master names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M tools/release/auto_roll.py View 1 1 chunk +1 line, -1 line 0 comments Download
M tools/release/test_scripts.py View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (6 generated)
Michael Achenbach
PTAL https://codereview.chromium.org/2111673003/diff/1/tools/release/auto_roll.py File tools/release/auto_roll.py (right): https://codereview.chromium.org/2111673003/diff/1/tools/release/auto_roll.py#newcode23 tools/release/auto_roll.py:23: CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel;tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel""") Unfortunately CQ doesn't support multiple occurrences of ...
4 years, 5 months ago (2016-06-30 14:02:23 UTC) #3
Michael Hablich
On 2016/06/30 14:02:23, Michael Achenbach wrote: > PTAL > > https://codereview.chromium.org/2111673003/diff/1/tools/release/auto_roll.py > File tools/release/auto_roll.py (right): ...
4 years, 5 months ago (2016-06-30 14:12:26 UTC) #4
Michael Achenbach
CC tandrii. Now added master. prefix everywhere to make new CQ happy.
4 years, 5 months ago (2016-06-30 14:13:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111673003/20001
4 years, 5 months ago (2016-06-30 14:13:29 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-30 14:15:39 UTC) #9
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-06-30 14:15:41 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/eb2a84d26fc62636b518d34a56559b25bd91be63 Cr-Commit-Position: refs/heads/master@{#37444}
4 years, 5 months ago (2016-06-30 14:18:45 UTC) #12
tandrii(chromium)
LGTM!
4 years, 5 months ago (2016-06-30 14:19:04 UTC) #14
Ken Russell (switch to Gerrit)
4 years, 5 months ago (2016-06-30 18:03:49 UTC) #15
Message was sent while issue was closed.
Excellent. Glad you will run the GPU tests on all platforms.

Note: Android tests are coming!

Powered by Google App Engine
This is Rietveld 408576698