Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2111653002: [Offline Pages] Adding metadatas for namespace async_loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixing tests. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index 8642ab137cadd30b0c337de6a28463c82e85c2d6..a967bc27fa3e94b952236c4df59aab9763a5d4f7 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -654,17 +654,18 @@ void OfflinePageModelImpl::OnExpirePageDone(int64_t offline_id,
if (iter != offline_pages_.end()) {
iter->second.expiration_time = expiration_time;
ClientId client_id = iter->second.client_id;
- UMA_HISTOGRAM_CUSTOM_COUNTS(
- AddHistogramSuffix(client_id, "OfflinePages.ExpirePage.PageLifetime")
- .c_str(),
- (expiration_time - iter->second.creation_time).InMinutes(), 1,
- base::TimeDelta::FromDays(30).InMinutes(), 50);
- UMA_HISTOGRAM_CUSTOM_COUNTS(
+ base::HistogramBase* histogram = base::Histogram::FactoryGet(
+ AddHistogramSuffix(client_id, "OfflinePages.ExpirePage.PageLifetime"),
+ 1, base::TimeDelta::FromDays(30).InMinutes(), 50,
+ base::HistogramBase::kUmaTargetedHistogramFlag);
+ histogram->Add((expiration_time - iter->second.creation_time).InMinutes());
+ histogram = base::Histogram::FactoryGet(
AddHistogramSuffix(client_id,
- "OfflinePages.ExpirePage.TimeSinceLastAccess")
- .c_str(),
- (expiration_time - iter->second.last_access_time).InMinutes(), 1,
- base::TimeDelta::FromDays(30).InMinutes(), 50);
+ "OfflinePages.ExpirePage.TimeSinceLastAccess"),
+ 1, base::TimeDelta::FromDays(30).InMinutes(), 50,
+ base::HistogramBase::kUmaTargetedHistogramFlag);
+ histogram->Add(
+ (expiration_time - iter->second.last_access_time).InMinutes());
}
}

Powered by Google App Engine
This is Rietveld 408576698