[Offline Pages] Adding metadatas for namespace async_loading.

components/offline_pages/offline_page_storage_manager.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/offline_pages/offline_page_storage_manager.h"
 
 #include <algorithm>
 
 #include "base/bind.h"
 #include "base/time/clock.h"
 #include "base/time/default_clock.h"
 #include "components/offline_pages/client_policy_controller.h"
 #include "components/offline_pages/offline_page_client_policy.h"
 #include "components/offline_pages/offline_page_item.h"
 #include "components/offline_pages/offline_page_model.h"
 
+using LifetimeType = offline_pages::LifetimePolicy::LifetimeType;
+
 namespace offline_pages {
 
 OfflinePageStorageManager::OfflinePageStorageManager(
     OfflinePageModel* model,
     ClientPolicyController* policy_controller,
     ArchiveManager* archive_manager)
     : model_(model),
       policy_controller_(policy_controller),
       archive_manager_(archive_manager),
       clock_(new base::DefaultClock()),
@@ skipping 74 matching lines @@
   }
   last_clear_time_ = clear_time_;
   callback.Run(pages_cleared, clear_result);
 }
 
 void OfflinePageStorageManager::GetPageIdsToClear(
     const MultipleOfflinePageItemResult& pages,
     const ArchiveManager::StorageStats& stats,
     std::vector<int64_t>* page_ids_to_expire,
     std::vector<int64_t>* page_ids_to_remove) {
+  // TODO(romax): See how persistent should be considered here.
   // Creating a map from namespace to a vector of page items.
   // Sort each vector based on last accessed time and all pages after index
   // min{size(), page_limit} should be expired. And then start iterating
   // backwards to expire pages.
   std::map<std::string, std::vector<OfflinePageItem>> pages_map;
   std::vector<OfflinePageItem> kept_pages;
   int64_t kept_pages_size = 0;
 
   for (const auto& page : pages) {
     if (!page.IsExpired()) {
@@ skipping 72 matching lines @@
     return ClearMode::DEFAULT;
   }
   // Otherwise there's no need to clear storage right now.
   return ClearMode::NOT_NEEDED;
 }
 
 bool OfflinePageStorageManager::ShouldBeExpired(
     const OfflinePageItem& page) const {
   const LifetimePolicy& policy =
       policy_controller_->GetPolicy(page.client_id.name_space).lifetime_policy;
-  return clear_time_ - page.last_access_time >= policy.expiration_period;
+  return policy.lifetime_type == LifetimeType::TEMPORARY &&
+         clear_time_ - page.last_access_time >= policy.expiration_period;
 }
 
 bool OfflinePageStorageManager::IsInProgress() const {
   return clear_time_ > last_clear_time_;
 }
 
 }  // namespace offline_pages