[MD Settings] Make Passwords and Autofill actionable if tap will work.

[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/710345ad1b827d9362f0b274005d928f46c4d1a0
Cr-Commit-Position: refs/heads/master@{#405897}

[hcarmona, 2016-06-30 23:54:52]

Description was changed from

==========
[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
==========

to

==========
[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-06-30 23:56:28]

hcarmona@chromium.org changed reviewers:
+ tommycli@chromium.org

[hcarmona, 2016-06-30 23:56:28]

PTAL

[Dan Beam, 2016-07-01 00:01:47]

dbeam@chromium.org changed reviewers:
+ dbeam@chromium.org

[Dan Beam, 2016-07-01 00:01:47]

this is slick

lgtm

bonus points for a test ;)

[tommycli, 2016-07-01 18:56:40]

lgtm

[hcarmona, 2016-07-06 23:52:34]

Added tests, PTAL.

[Dan Beam, 2016-07-07 00:05:02]

lgtm wish we could minimize the boilerplate though (michaelpg@ might have
thoughts about this)

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/passwords_and_forms_browsertest.js (right):

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/passwords_and_forms_browsertest.js:265: * @param
{boolean} passwords Whether passwords are enable or not.
enable -> enabled

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/passwords_and_forms_browsertest.js:268:
createPrefs(autofill, passwords) {
nit: arguably don't use ES6 features yet (i.e. createPrefs(autofill, password) {
=> createPrefs: function(autofill, passwords) {)

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/passwords_and_forms_browsertest.js:297:
console.log('destroying prefs');
nit: remove

[hcarmona, 2016-07-11 23:03:43]

Fix nits, committing.

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/passwords_and_forms_browsertest.js (right):

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/passwords_and_forms_browsertest.js:265: * @param
{boolean} passwords Whether passwords are enable or not.
On 2016/07/07 00:05:01, Dan Beam wrote:
> enable -> enabled

Done.

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/passwords_and_forms_browsertest.js:268:
createPrefs(autofill, passwords) {
On 2016/07/07 00:05:01, Dan Beam wrote:
> nit: arguably don't use ES6 features yet (i.e. createPrefs(autofill, password)
{
> => createPrefs: function(autofill, passwords) {)

Done.

https://codereview.chromium.org/2111643005/diff/20001/chrome/test/data/webui/...
chrome/test/data/webui/settings/passwords_and_forms_browsertest.js:297:
console.log('destroying prefs');
On 2016/07/07 00:05:01, Dan Beam wrote:
> nit: remove

Done.

[hcarmona, 2016-07-11 23:03:51]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-11 23:03:51]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2111643005/#ps40001
(title: "Nits")

[commit-bot: I haz the power, 2016-07-11 23:04:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-12 02:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-12 02:09:39]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hcarmona, 2016-07-13 18:23:56]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-13 18:24:19]

The CQ bit was unchecked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-07-13 18:24:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hcarmona, 2016-07-13 23:42:10]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-07-13 23:43:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 01:39:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-14 01:39:44]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hcarmona, 2016-07-14 23:49:06]

The CQ bit was checked by hcarmona@chromium.org

[commit-bot: I haz the power, 2016-07-14 23:49:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-14 23:49:40]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 01:06:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 01:06:41]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[hcarmona, 2016-07-15 22:33:31]

Description was changed from

==========
[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

[hcarmona, 2016-07-15 22:33:34]

The CQ bit was checked by hcarmona@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-15 22:33:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 22:34:00]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 23:29:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-15 23:29:22]

Dry run: This issue passed the CQ dry run.

[hcarmona, 2016-07-15 23:30:29]

The CQ bit was checked by hcarmona@chromium.org

[hcarmona, 2016-07-15 23:30:29]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org, dbeam@chromium.org
Link to the patchset: https://codereview.chromium.org/2111643005/#ps60001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-15 23:30:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-15 23:30:45]

Your CL relies on deprecated CQ feature(s):
 * Specifying master names in CQ_INCLUDE_TRYBOTS part of description without
"master." prefix is deprecated:
     tryserver.chromium.linux
   For more details, see http://crbug.com/617627.

[commit-bot: I haz the power, 2016-07-15 23:35:25]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-07-15 23:35:34]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-15 23:38:17]

Description was changed from

==========
[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings] Make Passwords and Autofill actionable if tap will work.

BUG=624722
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation;master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/710345ad1b827d9362f0b274005d928f46c4d1a0
Cr-Commit-Position: refs/heads/master@{#405897}
==========

[commit-bot: I haz the power, 2016-07-15 23:38:18]

Patchset 4 (id:??) landed as
https://crrev.com/710345ad1b827d9362f0b274005d928f46c4d1a0
Cr-Commit-Position: refs/heads/master@{#405897}