[ash-md] Adjusts animation of the selector after closing an overview item

ash/common/wm/overview/window_selector_item.cc

Index: ash/common/wm/overview/window_selector_item.cc
diff --git a/ash/common/wm/overview/window_selector_item.cc b/ash/common/wm/overview/window_selector_item.cc
index ea26f45327b331a5b4f57eedf44fd0ab1b085429..00713b004a802283fadc9266f49a7102c6de8fbc 100644
--- a/ash/common/wm/overview/window_selector_item.cc
+++ b/ash/common/wm/overview/window_selector_item.cc
@@ -414,6 +414,7 @@ void WindowSelectorItem::ButtonPressed(views::Button* sender,
       AnimateOpacity(
           0.0, OverviewAnimationType::OVERVIEW_ANIMATION_CLOSE_SELECTOR_ITEM);
     }
+    window_selector_->HideCurrentSelector();

[bruthig, 2016/07/05 14:27:03]

nit: I still think HideCurrentSelector() would be better named to indicate the
"what happened" signal, i.e. WindowClosed, as opposed to the action that is
supposed to happen.  I don't think the WindowSelectorItem should be the class
deciding when to show/hide the selector.  Renaming as such would make it a lot
more natural to add conditional logic to the method in WindowSelector.

Anyway, I feel like this may be very nit picky on my part so I will leave it to
your discretion.

[varkha, 2016/07/05 15:08:55]

Fair enough! Done.
Also thanks to your insistence I've noticed that I was fading out the selector
in any case - even if the item closing was not the one selected. This was masked
somewhat by quick fading in and repositioning of the selector but was quite
wrong. Thanks!

     transform_window_.Close();
     return;
   }