[ash-md] Adjusts animation of the selector after closing an overview item

ash/common/wm/overview/window_selector_item.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/overview/window_selector_item.h"
 
 #include <algorithm>
 #include <vector>
 
 #include "ash/common/material_design/material_design_controller.h"
@@ skipping 396 matching lines @@
       // Scale down both the window and label.
       SetBounds(inset_bounds, animation_type);
       // First animate opacity to an intermediate value concurrently with the
       // scaling animation.
       AnimateOpacity(kClosingItemOpacity, animation_type);
 
       // Fade out the window and the label, effectively hiding them.
       AnimateOpacity(
           0.0, OverviewAnimationType::OVERVIEW_ANIMATION_CLOSE_SELECTOR_ITEM);
     }
+    window_selector_->SetSelectorOpacity(0.f);

[bruthig, 2016/07/04 17:06:22]

I feel like the actual opacity value of the WindowSelector::selection_widget_
should be an internal detail of the WindowSelector class.  Perhaps calling an
event callback like WindowSelector::WindowClosed|Closing() that abstracts away
the opacity value from the clients would be better.

[varkha, 2016/07/04 18:01:30]

Done.

     transform_window_.Close();
     return;
   }
   CHECK(sender == window_label_button_view_);
   window_selector_->SelectWindow(transform_window_.window());
 }
 
 void WindowSelectorItem::OnWindowDestroying(WmWindow* window) {
   window->RemoveObserver(this);
   transform_window_.OnWindowDestroyed();
@@ skipping 212 matching lines @@
   window_label_selector_window->SetOpacity(opacity);
 }
 
 void WindowSelectorItem::UpdateCloseButtonAccessibilityName() {
   close_button_->SetAccessibleName(l10n_util::GetStringFUTF16(
       IDS_ASH_OVERVIEW_CLOSE_ITEM_BUTTON_ACCESSIBLE_NAME,
       GetWindow()->GetTitle()));
 }
 
 }  // namespace ash