Reland of Apply Referrer-Policy header when following redirects

Reland of Apply Referrer-Policy header when following redirects (patchset #1 id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17 id:320001 of https://codereview.chromium.org/2100583002/ )
>
> Reason for revert:
> Broke msan tests https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Tests/builds/17218/steps/net_unittests%20on%20Ubuntu-12.04/logs/URLRequestJob.RedirectTransactionWithReferrerPolicyHeader
>
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan: https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg3g/edit
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
>
> TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
>
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chromium.org
BUG=619228
Committed: https://crrev.com/5588c741ac6256115b545d29a4d4a7e87b68dddd
Cr-Commit-Position: refs/heads/master@{#403245}

[estark, 2016-06-30 16:56:58]

Created Reland of Apply Referrer-Policy header when following redirects

[mmenke, 2016-06-30 17:03:32]

What file is different?  Relands are much easier to review if you re-upload your
original CL first, and then upload a CL with the fix.

[estark, 2016-06-30 17:03:56]

Description was changed from

==========
Reland of Apply Referrer-Policy header when following redirects (patchset #1
id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17
id:320001 of https://codereview.chromium.org/2100583002/ )
> 
> Reason for revert:
> Broke msan tests
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test...
> 
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan:
https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg...
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
> 
>
TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
> 
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=619228
==========

to

==========
Reland of Apply Referrer-Policy header when following redirects (patchset #1
id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17
id:320001 of https://codereview.chromium.org/2100583002/ )
> 
> Reason for revert:
> Broke msan tests
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test...
> 
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan:
https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg...
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
> 
>
TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
> 
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
BUG=619228
==========

[estark, 2016-06-30 17:04:47]

On 2016/06/30 17:03:32, mmenke wrote:
> What file is different?  Relands are much easier to review if you re-upload
your
> original CL first, and then upload a CL with the fix.

I hadn't uploaded the diff yet. Now I uploaded it but I think I must have done
something wrong because it's showing a delta for lots of files. Hang on, let me
fix...

[estark, 2016-06-30 17:05:43]

Patchset #2 (id:260001) has been deleted

[mmenke, 2016-06-30 17:05:49]

On 2016/06/30 17:04:47, estark wrote:
> On 2016/06/30 17:03:32, mmenke wrote:
> > What file is different?  Relands are much easier to review if you re-upload
> your
> > original CL first, and then upload a CL with the fix.
> 
> I hadn't uploaded the diff yet. Now I uploaded it but I think I must have done
> something wrong because it's showing a delta for lots of files. Hang on, let
me
> fix...

Maybe that's the result of a merge?

[estark, 2016-06-30 17:08:25]

On 2016/06/30 17:05:49, mmenke wrote:
> On 2016/06/30 17:04:47, estark wrote:
> > On 2016/06/30 17:03:32, mmenke wrote:
> > > What file is different?  Relands are much easier to review if you
re-upload
> > your
> > > original CL first, and then upload a CL with the fix.
> > 
> > I hadn't uploaded the diff yet. Now I uploaded it but I think I must have
done
> > something wrong because it's showing a delta for lots of files. Hang on, let
> me
> > fix...
> 
> Maybe that's the result of a merge?

Yeah, I had a rebase in there, sorry. So Patch Set 1 is the original CL, Patch
Set 2 is now the rebase, Patch Set 3 is the fix
(https://codereview.chromium.org/2111623003/diff2/280001:300001/net/url_reques...).

[estark, 2016-06-30 17:11:01]

On 2016/06/30 17:08:25, estark wrote:
> On 2016/06/30 17:05:49, mmenke wrote:
> > On 2016/06/30 17:04:47, estark wrote:
> > > On 2016/06/30 17:03:32, mmenke wrote:
> > > > What file is different?  Relands are much easier to review if you
> re-upload
> > > your
> > > > original CL first, and then upload a CL with the fix.
> > > 
> > > I hadn't uploaded the diff yet. Now I uploaded it but I think I must have
> done
> > > something wrong because it's showing a delta for lots of files. Hang on,
let
> > me
> > > fix...
> > 
> > Maybe that's the result of a merge?
> 
> Yeah, I had a rebase in there, sorry. So Patch Set 1 is the original CL, Patch
> Set 2 is now the rebase, Patch Set 3 is the fix
>
(https://codereview.chromium.org/2111623003/diff2/280001:300001/net/url_reques...).

(In retrospect, not sure why I rebased, that was totally unnecessary.)

[mmenke, 2016-06-30 17:12:11]

On 2016/06/30 17:11:01, estark wrote:
> On 2016/06/30 17:08:25, estark wrote:
> > On 2016/06/30 17:05:49, mmenke wrote:
> > > On 2016/06/30 17:04:47, estark wrote:
> > > > On 2016/06/30 17:03:32, mmenke wrote:
> > > > > What file is different?  Relands are much easier to review if you
> > re-upload
> > > > your
> > > > > original CL first, and then upload a CL with the fix.
> > > > 
> > > > I hadn't uploaded the diff yet. Now I uploaded it but I think I must
have
> > done
> > > > something wrong because it's showing a delta for lots of files. Hang on,
> let
> > > me
> > > > fix...
> > > 
> > > Maybe that's the result of a merge?
> > 
> > Yeah, I had a rebase in there, sorry. So Patch Set 1 is the original CL,
Patch
> > Set 2 is now the rebase, Patch Set 3 is the fix
> >
>
(https://codereview.chromium.org/2111623003/diff2/280001:300001/net/url_reques...).
> 
> (In retrospect, not sure why I rebased, that was totally unnecessary.)

LGTM.  Think you can just TBR the other reviewers on this one, based on their
previous signoffs.  I was probably the only one reviewed that method (And yea, I
didn't check for uninitialized variables there).

[estark, 2016-06-30 17:55:30]

The CQ bit was checked by estark@chromium.org

[commit-bot: I haz the power, 2016-06-30 17:55:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 19:22:16]

Description was changed from

==========
Reland of Apply Referrer-Policy header when following redirects (patchset #1
id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17
id:320001 of https://codereview.chromium.org/2100583002/ )
> 
> Reason for revert:
> Broke msan tests
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test...
> 
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan:
https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg...
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
> 
>
TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
> 
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
BUG=619228
==========

to

==========
Reland of Apply Referrer-Policy header when following redirects (patchset #1
id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17
id:320001 of https://codereview.chromium.org/2100583002/ )
> 
> Reason for revert:
> Broke msan tests
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test...
> 
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan:
https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg...
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
> 
>
TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
> 
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
BUG=619228
==========

[commit-bot: I haz the power, 2016-06-30 19:22:18]

Committed patchset #3 (id:300001)

[commit-bot: I haz the power, 2016-06-30 19:22:30]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-30 19:25:48]

Description was changed from

==========
Reland of Apply Referrer-Policy header when following redirects (patchset #1
id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17
id:320001 of https://codereview.chromium.org/2100583002/ )
> 
> Reason for revert:
> Broke msan tests
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test...
> 
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan:
https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg...
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
> 
>
TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
> 
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
BUG=619228
==========

to

==========
Reland of Apply Referrer-Policy header when following redirects (patchset #1
id:1 of https://codereview.chromium.org/2108423002/ )

Reason for revert:
Relanding after fixing uninitialized |read_handler| field in MockTransaction

Original issue's description:
> Revert of Apply Referrer-Policy header when following redirects (patchset #17
id:320001 of https://codereview.chromium.org/2100583002/ )
>
> Reason for revert:
> Broke msan tests
https://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20MSan%20Test...
>
> Original issue's description:
> > Apply Referrer-Policy header when following redirects
> >
> > When a Referrer-Policy header is received during a redirect,
> > URLRequestJob parses it and updates the referrer and referrer policy on
> > the request, if necessary.
> >
> > The Referrer-Policy header is being implemented as an experimental web
> > platform feature. The experimental web platform feature flag is plumbed
> > to URLRequestJob via a boolean on URLRequestContext. This flag should be
> > temporary and only live until the Referrer-Policy feature ships.
> >
> > Intent to Implement:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Umj9iVRJM70
> > Implementation plan:
https://docs.google.com/document/d/1SyQhP6Y7BHIQXWL8S1saWqMuar4hoWLGigQuHmizg...
> >
> > BUG=619228
> >
> > Committed: https://crrev.com/550ba7f9533922cfeac9709d99815cec9b2ad52a
> > Cr-Commit-Position: refs/heads/master@{#403017}
>
>
TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG=619228
>
> Committed: https://crrev.com/ede2091f3f4a3a836e3e2efb13bd8c691a60f6d8
> Cr-Commit-Position: refs/heads/master@{#403075}

TBR=jochen@chromium.org,eugenebut@chromium.org,mmenke@chromium.org,palmer@chr...
BUG=619228

Committed: https://crrev.com/5588c741ac6256115b545d29a4d4a7e87b68dddd
Cr-Commit-Position: refs/heads/master@{#403245}
==========

[commit-bot: I haz the power, 2016-06-30 19:25:49]

Patchset 3 (id:??) landed as
https://crrev.com/5588c741ac6256115b545d29a4d4a7e87b68dddd
Cr-Commit-Position: refs/heads/master@{#403245}