Canvas objects did not mark themselves for layout when they're a flex item

Canvas objects did not mark themselves for layout when they're a flex item

See comment in patch -- when we're a flex item, we (likely)
have an override size, so updateLogicalHeight has no effect,
so the check if our size has changed has no effect. Skip
that if we have an override size.

TEST=css3/flexbox/canvas-dynamic-change.html
BUG=607314, 598212
R=eae@chromium.org,dgrogan@chromium.org

Committed: https://crrev.com/c43e0bb044f911727bcb340753de1fe03514a2ff
Cr-Commit-Position: refs/heads/master@{#402973}

[cbiesinger, 2016-06-29 19:58:37]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[cbiesinger, 2016-06-29 19:59:30]

cbiesinger@chromium.org changed reviewers:
+ junov@chromium.org

[cbiesinger, 2016-06-29 20:02:34]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 20:03:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-06-29 20:20:13]

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:838: if (1 ||
child.needsLayout() || childLayoutType == ForceLayout ||
!m_intrinsicSizeAlongMainAxis.contains(&child)) {
You probably forgot to remove this...

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp (right):

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp:60: if (zoomedSize ==
intrinsicSize()) {
Please either revert this style only change or change all the if statements in
the method.

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp:77: // If we have an
override size, then we're probably a flex item, and the
Nice comment!

[cbiesinger, 2016-06-29 20:36:42]

The CQ bit was checked by cbiesinger@chromium.org to run a CQ dry run

[cbiesinger, 2016-06-29 20:36:52]

PTAL!

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp (right):

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp:838: if (1 ||
child.needsLayout() || childLayoutType == ForceLayout ||
!m_intrinsicSizeAlongMainAxis.contains(&child)) {
On 2016/06/29 20:20:13, eae wrote:
> You probably forgot to remove this...

Yeah, included this entire file by accident :/

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp (right):

https://codereview.chromium.org/2111623002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/LayoutHTMLCanvas.cpp:60: if (zoomedSize ==
intrinsicSize()) {
On 2016/06/29 20:20:13, eae wrote:
> Please either revert this style only change or change all the if statements in
> the method.

Ah, oops, that was an accidental leftover.

[commit-bot: I haz the power, 2016-06-29 20:37:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eae, 2016-06-29 21:04:27]

Thanks, LGTM!

[commit-bot: I haz the power, 2016-06-29 21:34:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 21:34:32]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[cbiesinger, 2016-06-29 21:38:48]

The CQ bit was checked by cbiesinger@chromium.org

[commit-bot: I haz the power, 2016-06-29 21:47:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 22:44:20]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-29 22:44:23]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 22:47:36]

Description was changed from

==========
Canvas objects did not mark themselves for layout when they're a flex item

See comment in patch -- when we're a flex item, we (likely)
have an override size, so updateLogicalHeight has no effect,
so the check if our size has changed has no effect. Skip
that if we have an override size.

TEST=css3/flexbox/canvas-dynamic-change.html
BUG=607314,598212
R=eae@chromium.org,dgrogan@chromium.org
==========

to

==========
Canvas objects did not mark themselves for layout when they're a flex item

See comment in patch -- when we're a flex item, we (likely)
have an override size, so updateLogicalHeight has no effect,
so the check if our size has changed has no effect. Skip
that if we have an override size.

TEST=css3/flexbox/canvas-dynamic-change.html
BUG=607314,598212
R=eae@chromium.org,dgrogan@chromium.org

Committed: https://crrev.com/c43e0bb044f911727bcb340753de1fe03514a2ff
Cr-Commit-Position: refs/heads/master@{#402973}
==========

[commit-bot: I haz the power, 2016-06-29 22:47:37]

Patchset 3 (id:??) landed as
https://crrev.com/c43e0bb044f911727bcb340753de1fe03514a2ff
Cr-Commit-Position: refs/heads/master@{#402973}