components/ntp_snippets/ntp_snippets_service.cc - Issue 2111573002: Add ios_image_decoder_impl.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/ntp_snippets/ntp_snippets_service.cc

Issue 2111573002: Add ios_image_decoder_impl.* (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Modify the std::string to NSData conversion Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/ntp_snippets/ntp_snippets_service.cc

diff --git a/components/ntp_snippets/ntp_snippets_service.cc b/components/ntp_snippets/ntp_snippets_service.cc

index 48b3f0b11128729b6bde2273f06ad6b2b9e3d658..4168770210f621fd1089fdca8ee0d2ef2f7e48ca 100644

--- a/components/ntp_snippets/ntp_snippets_service.cc

+++ b/components/ntp_snippets/ntp_snippets_service.cc

@@ -629,7 +629,7 @@ void NTPSnippetsService::OnSnippetImageFetchedFromDatabase(

const std::string& snippet_id,

const ImageFetchedCallback& callback,

std::string data) {

- // |image_decoder_| is null on iOS and in tests.

+ // |image_decoder_| is null in tests.

if (image_decoder_ && !data.empty()) {

image_decoder_->DecodeImage(

std::move(data),