Device policy for LoginApps.

Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
TBR=bartfab@chromium.org

Committed: https://crrev.com/d90f54d47a575ba3217d4672ef6d61d74265527a
Cr-Commit-Position: refs/heads/master@{#403672}

[achuithb, 2016-06-29 14:28:52]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 14:29:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2016-06-29 14:37:32]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-29 14:37:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[achuithb, 2016-06-29 14:39:54]

achuith@chromium.org changed reviewers:
+ emaxx@chromium.org

[achuithb, 2016-06-29 14:39:55]

Maksim, please take a look.

[commit-bot: I haz the power, 2016-06-29 15:44:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 15:44:58]

Dry run: This issue passed the CQ dry run.

[emaxx, 2016-06-29 18:36:35]

lgtm with nits

https://codereview.chromium.org/2111563002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/2111563002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:714: // A list
of apps to install from the webstore on the login page.
nit: s/list of apps/list of app ids/ ?

https://codereview.chromium.org/2111563002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2111563002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:71812: +  <int value="335" label="List
of apps on the login screen"/>
nit: Looking at the existing labels in this file, I guess that the policy
caption should be more suitable here.

[achuithb, 2016-06-30 12:44:21]

https://codereview.chromium.org/2111563002/diff/20001/chrome/browser/chromeos...
File chrome/browser/chromeos/policy/proto/chrome_device_policy.proto (right):

https://codereview.chromium.org/2111563002/diff/20001/chrome/browser/chromeos...
chrome/browser/chromeos/policy/proto/chrome_device_policy.proto:714: // A list
of apps to install from the webstore on the login page.
On 2016/06/29 18:36:34, emaxx wrote:
> nit: s/list of apps/list of app ids/ ?

Done.

https://codereview.chromium.org/2111563002/diff/20001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2111563002/diff/20001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:71812: +  <int value="335" label="List
of apps on the login screen"/>
On 2016/06/29 18:36:34, emaxx wrote:
> nit: Looking at the existing labels in this file, I guess that the policy
> caption should be more suitable here.

I don't follow? I've changed this, but not sure if it's what you want.

[emaxx, 2016-06-30 12:49:40]

On 2016/06/30 12:44:21, achuithb wrote:
>
https://codereview.chromium.org/2111563002/diff/20001/tools/metrics/histogram...
> tools/metrics/histograms/histograms.xml:71812: +  <int value="335" label="List
> of apps on the login screen"/>
> On 2016/06/29 18:36:34, emaxx wrote:
> > nit: Looking at the existing labels in this file, I guess that the policy
> > caption should be more suitable here.
> 
> I don't follow? I've changed this, but not sure if it's what you want.

I meant that other labels related to policies in this file start with a verb.
And often the label here equals to the "caption" property value in
policy_templates.json.
So I was suggesting changing the new label to:
"Configure the list of installed apps on the login screen"

[achuithb, 2016-06-30 13:09:33]

On 2016/06/30 12:49:40, emaxx wrote:
> On 2016/06/30 12:44:21, achuithb wrote:
> >
>
https://codereview.chromium.org/2111563002/diff/20001/tools/metrics/histogram...
> > tools/metrics/histograms/histograms.xml:71812: +  <int value="335"
label="List
> > of apps on the login screen"/>
> > On 2016/06/29 18:36:34, emaxx wrote:
> > > nit: Looking at the existing labels in this file, I guess that the policy
> > > caption should be more suitable here.
> > 
> > I don't follow? I've changed this, but not sure if it's what you want.
> 
> I meant that other labels related to policies in this file start with a verb.
> And often the label here equals to the "caption" property value in
> policy_templates.json.
> So I was suggesting changing the new label to:
> "Configure the list of installed apps on the login screen"

Done. Thanks!

[achuithb, 2016-06-30 13:21:26]

achuith@chromium.org changed reviewers:
+ bartfab@chromium.org, isherman@chromium.org

[achuithb, 2016-06-30 13:21:27]

Bartosz: need an owner review for policy_templates.json.

Ilya: need an owner review of histograms.xml.

[achuithb, 2016-06-30 14:56:55]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-30 14:57:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-30 14:59:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-30 14:59:23]

Dry run: Try jobs failed on following builders:
  ios-device-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  ios-simulator-gn on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)

[Ilya Sherman, 2016-06-30 17:28:02]

histograms.xml lgtm

[achuithb, 2016-07-04 09:04:42]

The CQ bit was checked by achuith@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-04 09:04:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 10:04:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-04 10:04:45]

Dry run: This issue passed the CQ dry run.

[achuithb, 2016-07-04 12:46:34]

Description was changed from

==========
Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
==========

to

==========
Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
TBR=bartfab@chromium.org
==========

[achuithb, 2016-07-04 12:50:09]

achuith@chromium.org changed reviewers:
+ tnagel@chromium.org

[achuithb, 2016-07-04 12:50:09]

I've had to rebase this CL because someone added a policy, and I also need this
CL as a base for some follow-up work. While all of this is manageable, there's
only one file that needs an owner stamp, both bartfab@ and tnagel@ are traveling
on company business, so I'll TBR bartfab@ for now.

Thiemo/Bartosz - feel free to review at your leisure and if you have any
suggestions, I'll be glad to create a follow-up CL.

[achuithb, 2016-07-04 12:50:17]

The CQ bit was checked by achuith@chromium.org

[achuithb, 2016-07-04 12:50:17]

The patchset sent to the CQ was uploaded after l-g-t-m from emaxx@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/2111563002/#ps70001
(title: "rebase")

[commit-bot: I haz the power, 2016-07-04 12:50:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-04 12:55:55]

Description was changed from

==========
Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
TBR=bartfab@chromium.org
==========

to

==========
Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
TBR=bartfab@chromium.org
==========

[commit-bot: I haz the power, 2016-07-04 12:55:56]

Committed patchset #5 (id:70001)

[commit-bot: I haz the power, 2016-07-04 12:59:49]

Description was changed from

==========
Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
TBR=bartfab@chromium.org
==========

to

==========
Device policy for LoginApps.

This is just the boilerplate wiring of a device policy. It doesn't
actually affect anything.

BUG=576464
TBR=bartfab@chromium.org

Committed: https://crrev.com/d90f54d47a575ba3217d4672ef6d61d74265527a
Cr-Commit-Position: refs/heads/master@{#403672}
==========

[commit-bot: I haz the power, 2016-07-04 12:59:50]

Patchset 5 (id:??) landed as
https://crrev.com/d90f54d47a575ba3217d4672ef6d61d74265527a
Cr-Commit-Position: refs/heads/master@{#403672}