Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2111553003: fix skia unit tests (Closed)

Created:
4 years, 5 months ago by caryclark
Modified:
4 years, 5 months ago
Reviewers:
Lei Zhang, dsinclair
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix skia buildbots #

Patch Set 3 : fix luminosity device bitmap depth #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M core/fpdfapi/fpdf_render/fpdf_render_image.cpp View 1 2 3 chunks +9 lines, -1 line 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_loadimage_embeddertest.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M core/fpdfapi/fpdf_render/fpdf_render_pattern_embeddertest.cpp View 1 chunk +1 line, -6 lines 0 comments Download
M core/fxge/skia/fx_skia_device.h View 1 1 chunk +1 line, -0 lines 1 comment Download
M core/fxge/skia/fx_skia_device.cpp View 1 4 chunks +14 lines, -7 lines 1 comment Download
M core/fxge/skia/fx_skia_device_unittest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111553003/20001
4 years, 5 months ago (2016-06-29 16:06:12 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 16:19:27 UTC) #5
caryclark
4 years, 5 months ago (2016-06-29 16:46:41 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111553003/40001
4 years, 5 months ago (2016-06-29 17:26:43 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 17:39:19 UTC) #11
Lei Zhang
lgtm https://codereview.chromium.org/2111553003/diff/40001/core/fxge/skia/fx_skia_device.cpp File core/fxge/skia/fx_skia_device.cpp (right): https://codereview.chromium.org/2111553003/diff/40001/core/fxge/skia/fx_skia_device.cpp#newcode629 core/fxge/skia/fx_skia_device.cpp:629: if (m_pFont->GetFace() && m_pCache) { // exclude placeholder ...
4 years, 5 months ago (2016-06-29 18:19:23 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111553003/40001
4 years, 5 months ago (2016-06-29 19:10:37 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 19:10:55 UTC) #16
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/1e62a254e6a9ad8c6f18a8def3d104e0fe98...

Powered by Google App Engine
This is Rietveld 408576698