Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: tests/push-basic.sh

Issue 2111543002: Do not remove issue from branch after it is landed manually (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools
Patch Set: Fix Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/basic.sh ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/push-basic.sh
diff --git a/tests/push-basic.sh b/tests/push-basic.sh
index 0d434fa7cbbcb98ef9000e2e915b9c8e14912f2c..b9d09de7f1f6514d75f4c9f272d987ea5a245a4d 100755
--- a/tests/push-basic.sh
+++ b/tests/push-basic.sh
@@ -52,15 +52,15 @@ setup_gitgit
test_expect_success "git-cl land ok" \
"$GIT_CL land -f --no-oauth2"
+ test_expect_success "branch still has an issue" \
+ "$GIT_CL_STATUS | grep -q 'Issue number'"
+
git checkout -q master > /dev/null 2>&1
git pull -q > /dev/null 2>&1
test_expect_success "committed code has proper description" \
"git show | grep -q 'foo-quux'"
- test_expect_success "issue no longer has a branch" \
- "$GIT_CL_STATUS | grep -q 'work : None'"
-
cd $GITREPO_PATH
test_expect_success "upstream repo has our commit" \
"git log master 2>/dev/null | grep -q 'foo-quux'"
« no previous file with comments | « tests/basic.sh ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698