Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issue 2111543002: Do not remove issue from branch after it is landed manually (Closed)

Created:
4 years, 5 months ago by Sergiy Byelozyorov
Modified:
4 years, 5 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, tandrii+omg_git_cl_chromium.org, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Do not remove issue from branch after it is landed manually This is consistent with the way CQ works. Also git-cl-archive won't work if branch looses info about its matching CL. R=tandrii@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/2546dcc080884eb817ac0affbd3f16f6c156c2d5

Patch Set 1 #

Patch Set 2 : Fix #

Patch Set 3 : Fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -7 lines) Patch
M git_cl.py View 1 chunk +0 lines, -1 line 0 comments Download
M tests/basic.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M tests/push-basic.sh View 1 2 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
Sergiy Byelozyorov
4 years, 5 months ago (2016-06-29 13:41:32 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111543002/1
4 years, 5 months ago (2016-06-29 13:42:54 UTC) #3
tandrii(chromium)
LGTM (but git rebase-update would still cleanup this branch, and do other stuff, that you ...
4 years, 5 months ago (2016-06-29 13:43:46 UTC) #4
tandrii(chromium)
WARNING: while I think the change is reasonable, you have to on the lookout for ...
4 years, 5 months ago (2016-06-29 13:45:18 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/726)
4 years, 5 months ago (2016-06-29 13:49:22 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111543002/20001
4 years, 5 months ago (2016-06-29 14:14:03 UTC) #9
Sergiy Byelozyorov
On 2016/06/29 13:45:18, tandrii(chromium) wrote: > WARNING: while I think the change is reasonable, you ...
4 years, 5 months ago (2016-06-29 14:14:34 UTC) #10
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Depot Tools Presubmit on master.tryserver.infra (JOB_FAILED, https://build.chromium.org/p/tryserver.infra/builders/Depot%20Tools%20Presubmit/builds/728)
4 years, 5 months ago (2016-06-29 14:20:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111543002/40001
4 years, 5 months ago (2016-06-29 14:22:04 UTC) #15
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 14:26:43 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/tools/depot_tools/+/2546dcc080884e...

Powered by Google App Engine
This is Rietveld 408576698