Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2111503002: [ia32] Fixes a wrong use of Operand in a test. (Closed)

Created:
4 years, 5 months ago by epertoso
Modified:
4 years, 5 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ia32] Fixes a wrong use of Operand in a test. Operand(reg) -> reg Operand(reg, 0) -> [reg] BUG= Committed: https://crrev.com/c0d4bb89a1845bcc7a6d865e6c116d53514205ab Cr-Commit-Position: refs/heads/master@{#37370}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/cctest/test-assembler-ia32.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
epertoso
4 years, 5 months ago (2016-06-29 08:21:12 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111503002/1
4 years, 5 months ago (2016-06-29 08:21:14 UTC) #4
Benedikt Meurer
lgtm
4 years, 5 months ago (2016-06-29 08:36:22 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 5 months ago (2016-06-29 08:44:06 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111503002/1
4 years, 5 months ago (2016-06-29 08:45:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-06-29 08:52:39 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 08:54:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c0d4bb89a1845bcc7a6d865e6c116d53514205ab
Cr-Commit-Position: refs/heads/master@{#37370}

Powered by Google App Engine
This is Rietveld 408576698