go/src/infra/tools/cloudtail/client.go - Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: go/src/infra/tools/cloudtail/client.go

Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master

Patch Set: Updated monitoring proxy, cloudtail, and puppet metrics with the unit annotations. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: go/src/infra/tools/cloudtail/client.go

diff --git a/go/src/infra/tools/cloudtail/client.go b/go/src/infra/tools/cloudtail/client.go

index ffbb6d3647d17fa61560f74c0dc14e035c6eb098..2cd8c481ee2f6aeb45cf17538ca37004f502ad1f 100644

--- a/go/src/infra/tools/cloudtail/client.go

+++ b/go/src/infra/tools/cloudtail/client.go

@@ -14,6 +14,7 @@ import (

"github.com/luci/luci-go/common/logging"

"github.com/luci/luci-go/common/tsmon/field"

"github.com/luci/luci-go/common/tsmon/metric"

+ "github.com/luci/luci-go/common/tsmon/types"

"golang.org/x/net/context"

cloudlog "google.golang.org/api/logging/v1beta3"

)

@@ -77,12 +78,14 @@ type ClientOptions struct {

var (

entriesCounter = metric.NewCounter("cloudtail/log_entries",

"Log entries processed",

+ types.MetricMetadata{},

field.String("log"),

field.String("resource_type"),

field.String("resource_id"),

field.String("severity"))

writesCounter = metric.NewCounter("cloudtail/api_writes",

"Writes to Cloud Logging API",

+ types.MetricMetadata{},

field.String("log"),

field.String("resource_type"),

field.String("resource_id"),

« go/src/infra/monitoring/proxy/main.go ('K') | « go/src/infra/monitoring/proxy/pubsub.go ('k') | infra/services/sysmon/android_device_metrics.py » ('j') | no next file with comments »