Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(442)

Unified Diff: go/src/infra/monitoring/proxy/main.go

Issue 2111473003: Issue 623854: Support unit annotations in ts_mon metrics (Closed) Base URL: https://chromium.googlesource.com/infra/infra.git@master
Patch Set: Updated monitoring proxy, cloudtail, and puppet metrics with the unit annotations. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | go/src/infra/monitoring/proxy/pubsub.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: go/src/infra/monitoring/proxy/main.go
diff --git a/go/src/infra/monitoring/proxy/main.go b/go/src/infra/monitoring/proxy/main.go
index 038d75bd667d38341bbffa1311930db7554f076a..f77eb7747aafa9e3d47d688242428b5259bb95fa 100644
--- a/go/src/infra/monitoring/proxy/main.go
+++ b/go/src/infra/monitoring/proxy/main.go
@@ -25,6 +25,7 @@ import (
"github.com/luci/luci-go/common/tsmon/distribution"
"github.com/luci/luci-go/common/tsmon/field"
"github.com/luci/luci-go/common/tsmon/metric"
+ "github.com/luci/luci-go/common/tsmon/types"
"golang.org/x/net/context"
"google.golang.org/cloud/pubsub"
)
@@ -41,9 +42,11 @@ const (
var (
sentCount = metric.NewCounter("mon_proxy/endpoint/sent",
"Count of messages proxied to the endpoint",
+ types.MetricMetadata{},
Sergey Berezin 2016/07/06 22:01:24 I'd split the go changes into a separate CL. The r
ddoman 2016/07/07 05:06:39 Done.
field.String("result"))
sentDuration = metric.NewCumulativeDistribution("mon_proxy/endpoint/duration",
"Time taken to send messages to the endpoint, in milliseconds",
+ types.MetricMetadata{Units: types.Milliseconds},
distribution.DefaultBucketer)
)
« no previous file with comments | « no previous file | go/src/infra/monitoring/proxy/pubsub.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698