Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 2111463002: Add Mac, Win builders back to the CQ for extra coverage. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke
Modified:
4 years, 5 months ago
Reviewers:
jam, Paweł Hajdan Jr.
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add Mac, Win builders back to the CQ for extra coverage. Given that we're not going to ship GN-built Mac and Win releases in M53, let's add some GYP coverage back to the CQ; this'll make sure the targets the official builders really need build, although we won't run any tests. We should have capacity, but start with a 50% experiment for now. R=phajdan.jr@chromium.org, jam@chromium.org BUG=618468, 605318 CQ_INCLUDE_TRYBOTS=tryserver.chromium.mac:mac_chromium_gyp_rel;tryserver.chromium.win:win8_chromium_gyp_rel Committed: https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0 Cr-Commit-Position: refs/heads/master@{#402999}

Patch Set 1 #

Patch Set 2 : make chrome_official_builder, chrome_official_builder_no_unittests exist unconditionally on windows #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -73 lines) Patch
M BUILD.gn View 1 1 chunk +4 lines, -3 lines 0 comments Download
M build/all.gyp View 1 1 chunk +45 lines, -48 lines 0 comments Download
M infra/config/cq.cfg View 2 chunks +8 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 1 chunk +16 lines, -11 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 chunk +1 line, -11 lines 0 comments Download

Messages

Total messages: 24 (12 generated)
Dirk Pranke
4 years, 5 months ago (2016-06-29 04:58:58 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111463002/1
4 years, 5 months ago (2016-06-29 04:59:05 UTC) #4
commit-bot: I haz the power
Dry run: Transient error: Too many "tryserver.chromium.mac:mac_chromium_gyp_rel,tryserver.chromium.win:win8_chromium_gyp_rel" delimiters in ":". Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
4 years, 5 months ago (2016-06-29 04:59:09 UTC) #6
Paweł Hajdan Jr.
LGTM
4 years, 5 months ago (2016-06-29 10:18:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111463002/1
4 years, 5 months ago (2016-06-29 16:06:09 UTC) #9
commit-bot: I haz the power
Transient error: Too many "tryserver.chromium.mac:mac_chromium_gyp_rel,tryserver.chromium.win:win8_chromium_gyp_rel" delimiters in ":". Correct syntax is "tryserver:bot1,bot2;tryserver2:bot3,bot4;".
4 years, 5 months ago (2016-06-29 16:06:11 UTC) #11
jam
lgtm
4 years, 5 months ago (2016-06-29 18:14:09 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111463002/1
4 years, 5 months ago (2016-06-29 18:36:06 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: win8_chromium_gyp_rel on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gyp_rel/builds/1)
4 years, 5 months ago (2016-06-29 19:15:55 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2111463002/20001
4 years, 5 months ago (2016-06-29 22:18:30 UTC) #20
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-06-29 23:42:02 UTC) #22
commit-bot: I haz the power
4 years, 5 months ago (2016-06-29 23:44:55 UTC) #24
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6311f0fdc42799da33b9e28e6b784a1eda788aa0
Cr-Commit-Position: refs/heads/master@{#402999}

Powered by Google App Engine
This is Rietveld 408576698