Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(300)

Unified Diff: ash/wm/ash_focus_rules_unittest.cc

Issue 2111443002: mash: Migrate SessionStateDelegate access to WmShell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/wm/ash_focus_rules_unittest.cc
diff --git a/ash/wm/ash_focus_rules_unittest.cc b/ash/wm/ash_focus_rules_unittest.cc
index 24b3bd21ccff1d7ff977f339676722949be15509..180309be5239a2ccee291cf69fdaeba147e7b335 100644
--- a/ash/wm/ash_focus_rules_unittest.cc
+++ b/ash/wm/ash_focus_rules_unittest.cc
@@ -5,6 +5,7 @@
#include "ash/common/session/session_state_delegate.h"
#include "ash/common/shell_window_ids.h"
#include "ash/common/wm/window_state.h"
+#include "ash/common/wm_shell.h"
#include "ash/shell.h"
#include "ash/test/ash_test_base.h"
#include "ash/test/ash_test_helper.h"
@@ -118,8 +119,6 @@ class LockScreenAshFocusRulesTest : public AshTestBase {
return window;
}
- Shell* shell() const { return Shell::GetInstance(); }
-
private:
aura::Window* CreateWindowInContainer(int container_id) {
aura::Window* root_window = Shell::GetPrimaryRootWindow();
@@ -169,7 +168,7 @@ TEST_F(LockScreenAshFocusRulesTest, RegainFocusAfterUnlock) {
BlockUserSession(BLOCKED_BY_LOCK_SCREEN);
- EXPECT_TRUE(shell()->session_state_delegate()->IsScreenLocked());
+ EXPECT_TRUE(WmShell::Get()->GetSessionStateDelegate()->IsScreenLocked());
EXPECT_FALSE(normal_window->HasFocus());
EXPECT_FALSE(always_on_top_window->HasFocus());
EXPECT_FALSE(normal_window_state->IsMinimized());
@@ -179,7 +178,7 @@ TEST_F(LockScreenAshFocusRulesTest, RegainFocusAfterUnlock) {
UnblockUserSession();
- EXPECT_FALSE(shell()->session_state_delegate()->IsScreenLocked());
+ EXPECT_FALSE(WmShell::Get()->GetSessionStateDelegate()->IsScreenLocked());
EXPECT_FALSE(normal_window_state->IsMinimized());
EXPECT_FALSE(always_on_top_window_state->IsMinimized());
EXPECT_TRUE(normal_window_state->CanActivate());
@@ -192,7 +191,7 @@ TEST_F(LockScreenAshFocusRulesTest, RegainFocusAfterUnlock) {
// view doesn't get focused if the widget shows behind the lock screen.
TEST_F(LockScreenAshFocusRulesTest, PreventFocusChangeWithLockScreenPresent) {
BlockUserSession(BLOCKED_BY_LOCK_SCREEN);
- EXPECT_TRUE(shell()->session_state_delegate()->IsScreenLocked());
+ EXPECT_TRUE(WmShell::Get()->GetSessionStateDelegate()->IsScreenLocked());
views::test::TestInitialFocusWidgetDelegate delegate(CurrentContext());
EXPECT_FALSE(delegate.view()->HasFocus());
@@ -201,7 +200,7 @@ TEST_F(LockScreenAshFocusRulesTest, PreventFocusChangeWithLockScreenPresent) {
EXPECT_FALSE(delegate.view()->HasFocus());
UnblockUserSession();
- EXPECT_FALSE(shell()->session_state_delegate()->IsScreenLocked());
+ EXPECT_FALSE(WmShell::Get()->GetSessionStateDelegate()->IsScreenLocked());
EXPECT_TRUE(delegate.GetWidget()->IsActive());
EXPECT_TRUE(delegate.view()->HasFocus());
}

Powered by Google App Engine
This is Rietveld 408576698