Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: ash/wm/window_cycle_controller_unittest.cc

Issue 2111443002: mash: Migrate SessionStateDelegate access to WmShell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "ash/wm/window_cycle_controller.h" 5 #include "ash/wm/window_cycle_controller.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <memory> 8 #include <memory>
9 9
10 #include "ash/aura/wm_window_aura.h" 10 #include "ash/aura/wm_window_aura.h"
(...skipping 187 matching lines...) Expand 10 before | Expand all | Expand 10 after
198 controller->HandleCycleWindow(WindowCycleController::BACKWARD); 198 controller->HandleCycleWindow(WindowCycleController::BACKWARD);
199 EXPECT_TRUE(wm::IsActiveWindow(window2.get())); 199 EXPECT_TRUE(wm::IsActiveWindow(window2.get()));
200 controller->HandleCycleWindow(WindowCycleController::BACKWARD); 200 controller->HandleCycleWindow(WindowCycleController::BACKWARD);
201 EXPECT_TRUE(wm::IsActiveWindow(window1.get())); 201 EXPECT_TRUE(wm::IsActiveWindow(window1.get()));
202 controller->HandleCycleWindow(WindowCycleController::BACKWARD); 202 controller->HandleCycleWindow(WindowCycleController::BACKWARD);
203 EXPECT_TRUE(wm::IsActiveWindow(window0.get())); 203 EXPECT_TRUE(wm::IsActiveWindow(window0.get()));
204 controller->StopCycling(); 204 controller->StopCycling();
205 EXPECT_TRUE(wm::IsActiveWindow(window0.get())); 205 EXPECT_TRUE(wm::IsActiveWindow(window0.get()));
206 206
207 // When the screen is locked, cycling window does not take effect. 207 // When the screen is locked, cycling window does not take effect.
208 Shell::GetInstance()->session_state_delegate()->LockScreen(); 208 WmShell::Get()->GetSessionStateDelegate()->LockScreen();
209 EXPECT_TRUE(wm::IsActiveWindow(window0.get())); 209 EXPECT_TRUE(wm::IsActiveWindow(window0.get()));
210 controller->HandleCycleWindow(WindowCycleController::FORWARD); 210 controller->HandleCycleWindow(WindowCycleController::FORWARD);
211 EXPECT_TRUE(wm::IsActiveWindow(window0.get())); 211 EXPECT_TRUE(wm::IsActiveWindow(window0.get()));
212 controller->HandleCycleWindow(WindowCycleController::BACKWARD); 212 controller->HandleCycleWindow(WindowCycleController::BACKWARD);
213 EXPECT_TRUE(wm::IsActiveWindow(window0.get())); 213 EXPECT_TRUE(wm::IsActiveWindow(window0.get()));
214 214
215 Shell::GetInstance()->session_state_delegate()->UnlockScreen(); 215 WmShell::Get()->GetSessionStateDelegate()->UnlockScreen();
216 EXPECT_TRUE(wm::IsActiveWindow(window0.get())); 216 EXPECT_TRUE(wm::IsActiveWindow(window0.get()));
217 controller->HandleCycleWindow(WindowCycleController::FORWARD); 217 controller->HandleCycleWindow(WindowCycleController::FORWARD);
218 EXPECT_TRUE(wm::IsActiveWindow(window1.get())); 218 EXPECT_TRUE(wm::IsActiveWindow(window1.get()));
219 controller->HandleCycleWindow(WindowCycleController::FORWARD); 219 controller->HandleCycleWindow(WindowCycleController::FORWARD);
220 EXPECT_TRUE(wm::IsActiveWindow(window2.get())); 220 EXPECT_TRUE(wm::IsActiveWindow(window2.get()));
221 221
222 // When a modal window is active, cycling window does not take effect. 222 // When a modal window is active, cycling window does not take effect.
223 aura::Window* modal_container = ash::Shell::GetContainer( 223 aura::Window* modal_container = Shell::GetContainer(
224 Shell::GetPrimaryRootWindow(), kShellWindowId_SystemModalContainer); 224 Shell::GetPrimaryRootWindow(), kShellWindowId_SystemModalContainer);
225 std::unique_ptr<Window> modal_window( 225 std::unique_ptr<Window> modal_window(
226 CreateTestWindowWithId(-2, modal_container)); 226 CreateTestWindowWithId(-2, modal_container));
227 modal_window->SetProperty(aura::client::kModalKey, ui::MODAL_TYPE_SYSTEM); 227 modal_window->SetProperty(aura::client::kModalKey, ui::MODAL_TYPE_SYSTEM);
228 wm::ActivateWindow(modal_window.get()); 228 wm::ActivateWindow(modal_window.get());
229 EXPECT_TRUE(wm::IsActiveWindow(modal_window.get())); 229 EXPECT_TRUE(wm::IsActiveWindow(modal_window.get()));
230 controller->HandleCycleWindow(WindowCycleController::FORWARD); 230 controller->HandleCycleWindow(WindowCycleController::FORWARD);
231 EXPECT_TRUE(wm::IsActiveWindow(modal_window.get())); 231 EXPECT_TRUE(wm::IsActiveWindow(modal_window.get()));
232 EXPECT_FALSE(wm::IsActiveWindow(window0.get())); 232 EXPECT_FALSE(wm::IsActiveWindow(window0.get()));
233 EXPECT_FALSE(wm::IsActiveWindow(window1.get())); 233 EXPECT_FALSE(wm::IsActiveWindow(window1.get()));
(...skipping 392 matching lines...) Expand 10 before | Expand all | Expand 10 after
626 generator.PressKey(ui::VKEY_TAB, ui::EF_ALT_DOWN); 626 generator.PressKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
627 EXPECT_EQ(0u, key_count.GetCountAndReset()); 627 EXPECT_EQ(0u, key_count.GetCountAndReset());
628 generator.ReleaseKey(ui::VKEY_TAB, ui::EF_ALT_DOWN); 628 generator.ReleaseKey(ui::VKEY_TAB, ui::EF_ALT_DOWN);
629 EXPECT_EQ(0u, key_count.GetCountAndReset()); 629 EXPECT_EQ(0u, key_count.GetCountAndReset());
630 generator.ReleaseKey(ui::VKEY_MENU, ui::EF_NONE); 630 generator.ReleaseKey(ui::VKEY_MENU, ui::EF_NONE);
631 EXPECT_TRUE(wm::GetWindowState(w1.get())->IsActive()); 631 EXPECT_TRUE(wm::GetWindowState(w1.get())->IsActive());
632 EXPECT_EQ(0u, key_count.GetCountAndReset()); 632 EXPECT_EQ(0u, key_count.GetCountAndReset());
633 } 633 }
634 634
635 } // namespace ash 635 } // namespace ash
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698