src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp - Issue 2111423002: Fix caching of sample locations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp

Issue 2111423002: Fix caching of sample locations (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Some chrome bots don't have map::emplace. Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp

diff --git a/src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp b/src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp

index a52b1a638691340757bb1c6c5e4a925f439ef99e..5d1ba511b74b5809f5a2e787b44a994b1a2eacb8 100644

--- a/src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp

+++ b/src/gpu/glsl/GrGLSLFragmentShaderBuilder.cpp

@@ -365,7 +365,7 @@ void GrGLSLFragmentShaderBuilder::defineSampleOffsetArray(const char* name, cons

const GrGpu::MultisampleSpecs& specs = rtp.getMultisampleSpecs(pipeline.getStencil());

SkSTArray<16, SkPoint, true> offsets;

offsets.push_back_n(specs.fEffectiveSampleCnt);

- m.mapPoints(offsets.begin(), specs.fSampleLocations.get(), specs.fEffectiveSampleCnt);

+ m.mapPoints(offsets.begin(), specs.fSampleLocations, specs.fEffectiveSampleCnt);

this->definitions().append("const ");

if (fProgramBuilder->glslCaps()->usesPrecisionModifiers()) {

this->definitions().append("highp ");

« no previous file with comments | « src/gpu/gl/GrGLGpu.cpp ('k') | src/gpu/vk/GrVkGpu.h » ('j') | no next file with comments »